[GitHub] [spark] maropu commented on a change in pull request #28778: [SPARK-31949][SQL] Add spark.default.parallelism in SQLConf for isolated across session

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #28778:
URL: https://github.com/apache/spark/pull/28778#discussion_r438006123



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -371,6 +371,14 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val DEFAULT_PARALLELISM = buildConf("spark.sql.default.parallelism")
+    .doc("This config behavior is same as spark.default.parallelism, and this value can be " +
+      "isolated across sessions. Note: always use sc.defaultParallelism as default number.")

Review comment:
       ```
   The session-local default number of partitions and and this value is widely used inside physical plans.
   If not set, physical plans use `spark.sql.default.parallelism` instead.
   ```

##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -371,6 +371,14 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val DEFAULT_PARALLELISM = buildConf("spark.sql.default.parallelism")

Review comment:
       `spark.sql.default.parallelism` -> `spark.sql.sessionLocalDefaultParallelism`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org