You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@struts.apache.org by victorsosa <gi...@git.apache.org> on 2016/01/18 17:22:14 UTC

[GitHub] struts pull request: propose fix for ww-4456

GitHub user victorsosa opened a pull request:

    https://github.com/apache/struts/pull/74

    propose fix for ww-4456

    HI Lukasz,
    
    This is a proposal to fix WW-4456 - Got NPE when File Upload Limitation exceeds in portal env.
    
    We should catch in any case a FileUploadException, then try to cast down if we want any info about the exception. Valid subtype of FileUploadException:
    InvalidContentTypeException
    IOFileUploadException
    SizeLimitExceededException
    FileSizeLimitExceededException
    
    I couldn't get the complete test on a running test env, because I had issues getting the logging to work.
    
    But it seems to works.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/victorsosa/struts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit 073bb9dd587844c1f44c97ba53b8419c83f2583a
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-01-16T18:45:39Z

    Merge pull request #3 from apache/master
    
    update

commit 81675825723a0f4e7d4d185cd234cb2b900c2577
Author: Victor Sosa <vi...@gmail.com>
Date:   2016-01-18T15:34:36Z

    propose fix for WW-4456
    
    Got NPE when File Upload Limitation exceeds in portal env.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] struts pull request: propose fix for ww-4456

Posted by victorsosa <gi...@git.apache.org>.

Github user victorsosa closed the pull request at:

    https://github.com/apache/struts/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] struts pull request: propose fix for ww-4456

Posted by victorsosa <gi...@git.apache.org>.

Github user victorsosa commented on the pull request:

    https://github.com/apache/struts/pull/74#issuecomment-172694546
  
    Closed; Just got contaminated with other changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] struts pull request: propose fix for ww-4456

Posted by lukaszlenart <gi...@git.apache.org>.

Github user lukaszlenart commented on the pull request:

    https://github.com/apache/struts/pull/74#issuecomment-172753439
  
    The simplest approach it to not reverse merge `master` into your PRs till they are green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org