You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/07/31 11:42:43 UTC

[GitHub] [spark] LuciferYang opened a new pull request, #42239: [SPARK-44607][SQL] Remove unused function `containsNestedColumn` from `Filter`

LuciferYang opened a new pull request, #42239:
URL: https://github.com/apache/spark/pull/42239

   ### What changes were proposed in this pull request?
   This pr aims remove `private[sql] `function `containsNestedColumn` from `org.apache.spark.sql.sources.Filter`. 
   This function was introduced by https://github.com/apache/spark/pull/27728 to avoid nested predicate pushdown for Orc.
   After https://github.com/apache/spark/pull/28761, Orc also support nested column predicate pushdown, so this function become unused.
   
   ### Why are the changes needed?
   Remove unused `private[sql] ` function `containsNestedColumn`.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GitHub Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #42239: [SPARK-44607][SQL] Remove unused function `containsNestedColumn` from `Filter`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42239:
URL: https://github.com/apache/spark/pull/42239#issuecomment-1661427664

   Merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang closed pull request #42239: [SPARK-44607][SQL] Remove unused function `containsNestedColumn` from `Filter`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #42239: [SPARK-44607][SQL] Remove unused function `containsNestedColumn` from `Filter`
URL: https://github.com/apache/spark/pull/42239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #42239: [SPARK-44607][SQL] Remove unused function `containsNestedColumn` from `Filter`

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42239:
URL: https://github.com/apache/spark/pull/42239#issuecomment-1661427794

   Thanks @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org