You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Baris Acar (JIRA)" <ji...@apache.org> on 2013/09/23 23:47:03 UTC
[jira] [Commented] (CAMEL-6775) Aggregate - Potential little
optimization to send aggregated exchange to completion outside the lock
[ https://issues.apache.org/jira/browse/CAMEL-6775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775690#comment-13775690 ]
Baris Acar commented on CAMEL-6775:
-----------------------------------
Claus,
I see you've added the test to add a timeout but this causes the test to pass (after 5 seconds) even on Camel 2.11, which I think defeats the purpose of the test? (The test as it stands does not demonstrate that the behaviour has been fixed).
You may want to change
{code}
latch.await(5, TimeUnit.SECONDS);
{code}
to
{code}
if(!latch.await(5, TimeUnit.SECONDS)) {
throw new RuntimeException("Took too long; assume threads are blocked and fail test");
}
{code}
> Aggregate - Potential little optimization to send aggregated exchange to completion outside the lock
> ----------------------------------------------------------------------------------------------------
>
> Key: CAMEL-6775
> URL: https://issues.apache.org/jira/browse/CAMEL-6775
> Project: Camel
> Issue Type: Improvement
> Components: camel-core, eip
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.13.0
>
> Attachments: AggregatorLockingTest.java
>
>
> The aggregate eip needs to aggregate logic to operation in a lock. But if there is a completed aggregated exchange we can send that exchange to the downstream thread pool outside the lock.
> See nabble
> http://camel.465427.n5.nabble.com/Aggregator-lock-tp5739692.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira