[GitHub] [doris] kaijchen commented on a diff in pull request #21329: [refactor](load) move generate_delete_bitmap from memtable to beta rowset writer

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #21329:
URL: https://github.com/apache/doris/pull/21329#discussion_r1248022222


##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -141,6 +137,44 @@ Status BetaRowsetWriter::add_block(const vectorized::Block* block) {
     return _add_block(block, &_segment_writer);
 }
 
+Status BetaRowsetWriter::_generate_delete_bitmap(int32_t segment_id) {
+    SCOPED_RAW_TIMER(&_delete_bitmap_ns);
+    if (_context.tablet_schema->is_partial_update()) {

Review Comment:
   Thanks, updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org