You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rahul Akolkar <ra...@gmail.com> on 2010/06/09 15:59:25 UTC
[scxml-eclipse] Comments in Java code (was: svn commit: r953000)
See below:
On Wed, Jun 9, 2010 at 9:41 AM, <gu...@apache.org> wrote:
> Author: guixl
> Date: Wed Jun 9 13:41:14 2010
> New Revision: 953000
>
> URL: http://svn.apache.org/viewvc?rev=953000&view=rev
> Log:
> add SCXML document export progress monitor
>
> Added:
> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ExportProgressMonitor.java (with props)
> Modified:
> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ModelingDocumentExportWizard.java
>
<snip/>
>
> /**
> * Scxml document export wizard
> + *
> * @author Gui Xun Long (guixl@apache.org)
> */
> public class ModelingDocumentExportWizard extends Wizard {
<snap/>
For various reasons (I can elaborate if needed), the use of @author
tags in new code is discouraged. Indeed, Commons SCXML for example,
has no @author tags. I'd suggest removing these tags from
[scxml-eclipse].
> +
> + /*// ¿ªÊ¼´¦Àí½ø¶È£¬Èç¹ûindeterminateΪfalse,Õû¸ö½ø¶ÈΪTOTAL_TIME = 10000
> + // ·ñÔò£¬½ø¶ÈÌõΪ×Ô¶¯Ôö¼ÓµÄ
> + for (int total = 0; total < TOTAL_TIME && !monitor.isCanceled(); total += INCREMENT) {
> + Thread.sleep(INCREMENT);
> + monitor.worked(INCREMENT);
> + // µ½´ïÒ»°ëµÄʱ¼äÏÔʾÏàÓ¦µÄÐÅÏ¢
> + if (total == TOTAL_TIME / 2)
<snap/>
Comments above are garbled (please make sure all your comments are in English).
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [scxml-eclipse] Comments in Java code (was: svn commit: r953000)
Posted by Xun Long Gui <us...@gmail.com>.
Yeah
2010/6/9 Rahul Akolkar <ra...@gmail.com>
> On Wed, Jun 9, 2010 at 11:03 AM, Xun Long Gui <us...@gmail.com> wrote:
> > Sorry about Chinese commend in source code, i will fix it
> >
> <snip/>
>
> OK, and are you planning on removing the @author tags as well while
> you are at it?
>
> -Rahul
>
>
> > 2010/6/9 Rahul Akolkar <ra...@gmail.com>
> >
> >> See below:
> >>
> >> On Wed, Jun 9, 2010 at 9:41 AM, <gu...@apache.org> wrote:
> >> > Author: guixl
> >> > Date: Wed Jun 9 13:41:14 2010
> >> > New Revision: 953000
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=953000&view=rev
> >> > Log:
> >> > add SCXML document export progress monitor
> >> >
> >> > Added:
> >> >
> >>
> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ExportProgressMonitor.java
> >> (with props)
> >> > Modified:
> >> >
> >>
> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ModelingDocumentExportWizard.java
> >> >
> >> <snip/>
> >> >
> >> > /**
> >> > * Scxml document export wizard
> >> > + *
> >> > * @author Gui Xun Long (guixl@apache.org)
> >> > */
> >> > public class ModelingDocumentExportWizard extends Wizard {
> >> <snap/>
> >>
> >> For various reasons (I can elaborate if needed), the use of @author
> >> tags in new code is discouraged. Indeed, Commons SCXML for example,
> >> has no @author tags. I'd suggest removing these tags from
> >> [scxml-eclipse].
> >>
> >>
> >>
> >> > +
> >> > + /*//
> >> ¿ªÊ¼´¦Àí½ø¶È£¬Èç¹ûindeterminateΪfalse,Õû¸ö½ø¶ÈΪTOTAL_TIME = 10000
> >> > + // ·ñÔò£¬½ø¶ÈÌõΪ×Ô¶¯Ôö¼ÓµÄ
> >> > + for (int total = 0; total < TOTAL_TIME &&
> >> !monitor.isCanceled(); total += INCREMENT) {
> >> > + Thread.sleep(INCREMENT);
> >> > + monitor.worked(INCREMENT);
> >> > + // µ½´ïÒ»°ëµÄʱ¼äÏÔʾÏàÓ¦µÄÐÅÏ¢
> >> > + if (total == TOTAL_TIME / 2)
> >> <snap/>
> >>
> >> Comments above are garbled (please make sure all your comments are in
> >> English).
> >>
> >> -Rahul
> >>
> >
> >
> > --
> > Best Regards
> >
> > Gui Xun Long (桂训龙)
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
Best Regards
Gui Xun Long (桂训龙)
Re: [scxml-eclipse] Comments in Java code (was: svn commit: r953000)
Posted by Rahul Akolkar <ra...@gmail.com>.
On Wed, Jun 9, 2010 at 11:03 AM, Xun Long Gui <us...@gmail.com> wrote:
> Sorry about Chinese commend in source code, i will fix it
>
<snip/>
OK, and are you planning on removing the @author tags as well while
you are at it?
-Rahul
> 2010/6/9 Rahul Akolkar <ra...@gmail.com>
>
>> See below:
>>
>> On Wed, Jun 9, 2010 at 9:41 AM, <gu...@apache.org> wrote:
>> > Author: guixl
>> > Date: Wed Jun 9 13:41:14 2010
>> > New Revision: 953000
>> >
>> > URL: http://svn.apache.org/viewvc?rev=953000&view=rev
>> > Log:
>> > add SCXML document export progress monitor
>> >
>> > Added:
>> >
>> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ExportProgressMonitor.java
>> (with props)
>> > Modified:
>> >
>> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ModelingDocumentExportWizard.java
>> >
>> <snip/>
>> >
>> > /**
>> > * Scxml document export wizard
>> > + *
>> > * @author Gui Xun Long (guixl@apache.org)
>> > */
>> > public class ModelingDocumentExportWizard extends Wizard {
>> <snap/>
>>
>> For various reasons (I can elaborate if needed), the use of @author
>> tags in new code is discouraged. Indeed, Commons SCXML for example,
>> has no @author tags. I'd suggest removing these tags from
>> [scxml-eclipse].
>>
>>
>>
>> > +
>> > + /*//
>> ¿ªÊ¼´¦Àí½ø¶È£¬Èç¹ûindeterminateΪfalse,Õû¸ö½ø¶ÈΪTOTAL_TIME = 10000
>> > + // ·ñÔò£¬½ø¶ÈÌõΪ×Ô¶¯Ôö¼ÓµÄ
>> > + for (int total = 0; total < TOTAL_TIME &&
>> !monitor.isCanceled(); total += INCREMENT) {
>> > + Thread.sleep(INCREMENT);
>> > + monitor.worked(INCREMENT);
>> > + // µ½´ïÒ»°ëµÄʱ¼äÏÔʾÏàÓ¦µÄÐÅÏ¢
>> > + if (total == TOTAL_TIME / 2)
>> <snap/>
>>
>> Comments above are garbled (please make sure all your comments are in
>> English).
>>
>> -Rahul
>>
>
>
> --
> Best Regards
>
> Gui Xun Long (桂训龙)
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [scxml-eclipse] Comments in Java code (was: svn commit: r953000)
Posted by Xun Long Gui <us...@gmail.com>.
Sorry about Chinese commend in source code, i will fix it
2010/6/9 Rahul Akolkar <ra...@gmail.com>
> See below:
>
> On Wed, Jun 9, 2010 at 9:41 AM, <gu...@apache.org> wrote:
> > Author: guixl
> > Date: Wed Jun 9 13:41:14 2010
> > New Revision: 953000
> >
> > URL: http://svn.apache.org/viewvc?rev=953000&view=rev
> > Log:
> > add SCXML document export progress monitor
> >
> > Added:
> >
> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ExportProgressMonitor.java
> (with props)
> > Modified:
> >
> commons/sandbox/gsoc/2010/scxml-eclipse/trunk/src/main/java/org.apache.commons.scxml.modeling.diagram/src/org/apache/commons/scxml/modeling/export/ModelingDocumentExportWizard.java
> >
> <snip/>
> >
> > /**
> > * Scxml document export wizard
> > + *
> > * @author Gui Xun Long (guixl@apache.org)
> > */
> > public class ModelingDocumentExportWizard extends Wizard {
> <snap/>
>
> For various reasons (I can elaborate if needed), the use of @author
> tags in new code is discouraged. Indeed, Commons SCXML for example,
> has no @author tags. I'd suggest removing these tags from
> [scxml-eclipse].
>
>
>
> > +
> > + /*//
> ¿ªÊ¼´¦Àí½ø¶È£¬Èç¹ûindeterminateΪfalse,Õû¸ö½ø¶ÈΪTOTAL_TIME = 10000
> > + // ·ñÔò£¬½ø¶ÈÌõΪ×Ô¶¯Ôö¼ÓµÄ
> > + for (int total = 0; total < TOTAL_TIME &&
> !monitor.isCanceled(); total += INCREMENT) {
> > + Thread.sleep(INCREMENT);
> > + monitor.worked(INCREMENT);
> > + // µ½´ïÒ»°ëµÄʱ¼äÏÔʾÏàÓ¦µÄÐÅÏ¢
> > + if (total == TOTAL_TIME / 2)
> <snap/>
>
> Comments above are garbled (please make sure all your comments are in
> English).
>
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
Best Regards
Gui Xun Long (桂训龙)