[jira] [Comment Edited] (KAFKA-10434) Remove deprecated methods on WindowStore

["Sophie Blee-Goldman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184804#comment-17184804 ] 

Sophie Blee-Goldman edited comment on KAFKA-10434 at 8/26/20, 12:20 AM:
------------------------------------------------------------------------

Also, if there are performance concerns with using Instant, then why did we deprecate all of the public APIs that use long? We shouldn't set the bar lower for users of IQ, we have no idea what their performance requirements might be and they could be making many calls per second. I think we should un-deprecate them...

Of course, if we're going to be completely overhauling IQ shortly anyways, maybe it's not worth a KIP to un-deprecate it (do we actually need a KIP for that?) It just seems weird to force the tradeoff onto users of IQ 


was (Author: ableegoldman):
Also, if there are performance concerns with using Instant, then why did we deprecate all of the public APIs that use long? We shouldn't set the bar lower for our own internal use vs users of IQ, we have no idea what their performance requirements might be and they could be making many calls per second. I think we should un-deprecate them...

Of course, if we're going to be completely overhauling IQ shortly anyways, maybe it's not worth a KIP to un-deprecate it (do we actually need a KIP for that?) It just seems weird to force the tradeoff onto users of IQ 

> Remove deprecated methods on WindowStore
> ----------------------------------------
>
>                 Key: KAFKA-10434
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10434
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Jorge Esteban Quilcate Otoya
>            Priority: Major
>
> From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and [https://github.com/apache/kafka/pull/9138#discussion_r474995606] :
> WindowStore contains ReadOnlyWindowStore methods.
> We could consider:
>  * Moving read methods from WindowStore to ReadOnlyWindowStore and/or
>  * Consider removing long based methods



--
This message was sent by Atlassian Jira
(v8.3.4#803005)