You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/29 17:39:23 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #181: Fix an inverted logic in the following commit.

yamt commented on a change in pull request #181: Fix an inverted logic in the following commit.
URL: https://github.com/apache/incubator-nuttx/pull/181#discussion_r372530144
 
 

 ##########
 File path: arch/sim/src/sim/up_setjmp32.S
 ##########
 @@ -47,9 +47,9 @@
 # define SYMBOL(s) _##s
 #else
 #ifdef __ELF__
-# define SYMBOL(s) _##s
-#else
 # define SYMBOL(s) s
+#else
+# define SYMBOL(s) _##s
 #endif
 #endif
 
 
 Review comment:
   do you mean to merge __CYGWIN__ block?
   __CYGWIN__ seems to use _ prefix for 32-bit but not for 64-bit.
   so I feel it's better to keep it separate.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services