You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/08/21 07:47:20 UTC
[GitHub] [incubator-eventmesh] horoc opened a new pull request, #1171: [Enhancement] Remove some unused local variables
horoc opened a new pull request, #1171:
URL: https://github.com/apache/incubator-eventmesh/pull/1171
Fixes #1170
### Motivation
Remove unused local variables which aim to keep code clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1171: [Enhancement] Remove some unused local variables
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1171:
URL: https://github.com/apache/incubator-eventmesh/pull/1171#issuecomment-1221495387
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1171](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18e9af5) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/8b2f3fd38051fa85fe0f48421eb12e4d03205b42?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b2f3fd) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1171 +/- ##
===========================================
- Coverage 9.99% 9.88% -0.11%
+ Complexity 644 637 -7
===========================================
Files 382 382
Lines 23640 23628 -12
Branches 2619 2615 -4
===========================================
- Hits 2362 2336 -26
- Misses 21057 21069 +12
- Partials 221 223 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/eventmesh/protocol/http/HttpProtocolAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sQWRhcHRvci5qYXZh) | `5.88% <ø> (+0.16%)` | :arrow_up: |
| [...ocol/http/processor/BatchSendMessageProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvQmF0Y2hTZW5kTWVzc2FnZVByb2Nlc3Nvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...l/http/processor/LocalSubscribeEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvTG9jYWxTdWJzY3JpYmVFdmVudFByb2Nlc3Nvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...http/processor/LocalUnSubscribeEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvTG9jYWxVblN1YnNjcmliZUV2ZW50UHJvY2Vzc29yLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../http/processor/RemoteSubscribeEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvUmVtb3RlU3Vic2NyaWJlRXZlbnRQcm9jZXNzb3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ttp/processor/RemoteUnSubscribeEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvUmVtb3RlVW5TdWJzY3JpYmVFdmVudFByb2Nlc3Nvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...otocol/http/processor/SendAsyncEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvU2VuZEFzeW5jRXZlbnRQcm9jZXNzb3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../http/processor/SendAsyncRemoteEventProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvU2VuZEFzeW5jUmVtb3RlRXZlbnRQcm9jZXNzb3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...rotocol/tcp/client/session/push/SessionPusher.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvU2Vzc2lvblB1c2hlci5qYXZh) | `0.00% <ø> (ø)` | |
| [.../protocol/tcp/client/task/MessageTransferTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL01lc3NhZ2VUcmFuc2ZlclRhc2suamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1171/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #1171: [Enhancement] Remove some unused local variables
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #1171:
URL: https://github.com/apache/incubator-eventmesh/pull/1171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org