You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/06/10 06:03:56 UTC

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23002


Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................

WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

WIP:
  * collect & address feedback on this approach

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
4 files changed, 332 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#4).

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................

WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

WIP:
  * collect & address feedback on this approach

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/CMakeLists.txt
A src/kudu/common/array_view.cc
A src/kudu/common/array_view.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/master/master-test.cc
16 files changed, 839 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#7).

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................

WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

WIP:
  * address TODO(s)
  * clean-up array_view.h
  * add more tests
  * add a notion on not-yet supported columns of INT128 and DECIMAL128
    arrays (maybe, in a separate patch?)

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/master/master-test.cc
12 files changed, 622 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/7
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 5: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1724/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 30 Aug 2025 05:36:37 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 10:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1781/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 00:27:58 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#12).

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................

KUDU-1261 introduce 1D arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
15 files changed, 939 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/12
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 12
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................

KUDU-1261 introduce 1D arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Reviewed-on: http://gerrit.cloudera.org:8080/23002
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
15 files changed, 939 insertions(+), 42 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 13
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1552/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jul 2025 05:19:35 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1434/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 06:04:05 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 10: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1781/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 02:25:55 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#3).

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................

WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

WIP:
  * collect & address feedback on this approach

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/master/master-test.cc
5 files changed, 422 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 11: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1788/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 11
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 20:48:19 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1436/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 09:36:04 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#9).

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................

KUDU-1261 introduce 1D arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
15 files changed, 836 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/9
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#10).

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................

KUDU-1261 introduce 1D arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
15 files changed, 928 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/10
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#6).

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................

WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

WIP:
  * address TODO(s)
  * clean-up array_view.h
  * add more tests

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
A src/kudu/common/array_view.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/master/master-test.cc
13 files changed, 761 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/6
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 12: Verified+1

unrelated test failrues:
  * DEBUG, ASAN: known flaky Java tests
  * TSAN: known flaky Java tests; KUDU-3660


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 12
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 23:52:45 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 12
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 10: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1782/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 04:56:38 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#2).

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................

WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

WIP:
  * collect & address feedback on this approach

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
4 files changed, 332 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1621/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Jul 2025 19:37:42 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1434/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 06:07:33 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23002/9/src/kudu/client/schema.h
File src/kudu/client/schema.h:

http://gerrit.cloudera.org:8080/#/c/23002/9/src/kudu/client/schema.h@299
PS9, Line 299:     const KuduNestedType kind_;
             : 
             :     union Descriptor {
             :       explicit Descriptor(const KuduArrayTypeDescriptor& desc);
             :       ~Descriptor();
             : 
             :       const KuduArrayTypeDescriptor array;
             :     } descriptor_;
I think a better approach here is to use the PIMPL idiom, hiding implementation details for more freedom in updating this in future without bothering about the ABI compatibility.  Also, that way the issue with  KuduArrayTypeDescriptor's constructor will be automatically resolved as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Sep 2025 06:56:37 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/schema-test.cc@456
PS11, Line 456: ASSERT_TRUE(col0.Equals(col1, ColumnSchema::COMPARE_NAME));
> nit: duplicate
Done


http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:

PS11: 
> Maybe also check how ColumnSchemaBuilderFromPB behaves if array PB exists b
Such a scenario was present already: see lines 890-902 in PS11.  The 'inverse' scenario was also present: see lines 903-914 in PS11.



-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 11
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 22:01:10 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1733/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 16:09:39 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 7:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1761/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Sep 2025 05:39:09 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 2: Verified+1

Unrelated dist-test CI failure (DEBUG)


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 17:00:46 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1436/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Jun 2025 06:49:16 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1621/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Jul 2025 20:08:17 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 12: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:

PS11: 
> Such a scenario was present already: see lines 890-902 in PS11.  The 'inver
Ah, yep I missed it , thanks!



-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 12
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Sep 2025 05:27:45 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 12:

> (1 comment)

Thank you for review!


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 12
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Sep 2025 05:41:29 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 6: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1733/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 16:35:24 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 8: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1772/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Sep 2025 23:29:48 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1552/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jul 2025 05:30:45 +0000
Gerrit-HasComments: No

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 7: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1761/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Sep 2025 08:08:01 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 9: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1777/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Sep 2025 08:15:31 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#8).

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................

KUDU-1261 introduce 1D arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
14 files changed, 910 insertions(+), 94 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/8
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 8:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1772/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Sep 2025 20:32:52 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 11:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1788/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 11
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 18:47:22 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 12:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1791/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 12
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 21:58:19 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 10: Verified+1

unrelated test failures:
  * ASAN: known Java flaky tests
  * TSAN: KUDU-3660, known flaky Java tests


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 05:33:51 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 9: Verified+1

unrelated test failures:
* DEBUG: known Java flaky tests
* TSAN: known Java flaky tests, KUDU-3660


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Sep 2025 14:05:41 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 9:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1777/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Sep 2025 06:47:00 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23002

to look at the new patch set (#11).

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................

KUDU-1261 introduce 1D arrays into ColumnSchema

This changelist introduces support for one-dimensional arrays into
ColumnSchema, ColumnSchemaBuilder, and ColumnSchemaBuilderFromPB()
utility function.  The newly introduced functionality comes with
basic test coverage.

Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/common/row.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/row_operations.proto
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
15 files changed, 928 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/23002/11
-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 11
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 10: -Verified

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1782/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 10
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 03:52:58 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/schema-test.cc@456
PS11, Line 456: ASSERT_TRUE(col0.Equals(col1, ColumnSchema::COMPARE_NAME));
nit: duplicate


http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:

PS11: 
Maybe also check how ColumnSchemaBuilderFromPB behaves if array PB exists but has no type set.



-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 11
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 20:43:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP KUDU-1261 introduce 1D-arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: WIP KUDU-1261 introduce 1D-arrays into ColumnSchema
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1724/


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 30 Aug 2025 05:13:18 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 introduce 1D arrays into ColumnSchema

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )

Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema
......................................................................


Patch Set 12: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1791/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270
Gerrit-Change-Number: 23002
Gerrit-PatchSet: 12
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 23:47:10 +0000
Gerrit-HasComments: No