You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/23 16:29:16 UTC
[GitHub] [camel-k] squakez opened a new pull request #2775: fix(build): default jitpack to main
squakez opened a new pull request #2775:
URL: https://github.com/apache/camel-k/pull/2775
* Moved default from master to main
* Added some meaningful example
Closes #2764
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2775: fix(build): default jitpack to main
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2775:
URL: https://github.com/apache/camel-k/pull/2775#issuecomment-977878736
CI is failing because #2742 not related to the change done here. I'll merge if no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #2775: fix(build): default jitpack to main
Posted by GitBox <gi...@apache.org>.
squakez merged pull request #2775:
URL: https://github.com/apache/camel-k/pull/2775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a change in pull request #2775: fix(build): default jitpack to main
Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #2775:
URL: https://github.com/apache/camel-k/pull/2775#discussion_r755681491
##########
File path: pkg/util/jitpack/jitpack.go
##########
@@ -24,10 +24,13 @@ import (
)
const (
- RepoURL = "https://jitpack.io"
- LatestVersion = "master-SNAPSHOT"
+ // RepoURL is the Jitpack repository url
+ RepoURL = "https://jitpack.io"
+ // DefaultVersion is the default branch/version to use
+ DefaultVersion = "main-SNAPSHOT"
)
+// ToDependency converts a jitpack dependency into Depdendency struct
Review comment:
Not a big deal, but a small typo: `Depdendency` -> `Dependency`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org