You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Azrael Park <az...@nexr.com> on 2014/07/11 09:29:23 UTC
Review Request 23407: OOZIE-1927 Use StoreStatusFilter for
WorkflowsJobGetJPAExecutor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23407/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1927
https://issues.apache.org/jira/browse/OOZIE-1927
Repository: oozie-git
Description
-------
There is code in StoreStatusFilter#filter to apply filter for getting job info.
This patch remove the duplicated code and make simple to create query.
* Add StoreStatusFilter#parseFilter() to use parsing filter string for wf, coord, bundle.
* Use StoreStatusFilter#filter() to create query for getting wf, coord, bundle
Diffs
-----
core/src/main/java/org/apache/oozie/BundleEngine.java 67f4aba
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1011b9e
core/src/main/java/org/apache/oozie/DagEngine.java f6e5b4f
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java c663e07
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 8008737
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 6750501
core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 9021778
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java 8025b75
core/src/main/java/org/apache/oozie/store/WorkflowStore.java fe43130
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java e3db675
core/src/test/java/org/apache/oozie/TestDagEngine.java 33dc97f
core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java ff87c10
core/src/test/java/org/apache/oozie/store/TestStoreStatusFilter.java PRE-CREATION
Diff: https://reviews.apache.org/r/23407/diff/
Testing
-------
Unit test done.
Manual test done.
Thanks,
Azrael Park