You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2015/02/20 00:05:36 UTC
[Issue 126118] New: malformed make conditions in /vcl/Module_vcl.mk
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Issue ID: 126118
Issue Type: DEFECT
Summary: malformed make conditions in /vcl/Module_vcl.mk
Product: Build Tools
Version: 4.2.0-dev
Hardware: PC
OS: Linux32
Status: CONFIRMED
Severity: normal
Priority: P5
Component: dmake
Assignee: issues@openoffice.apache.org
Reporter: kschenk@apache.org
Created attachment 84515
--> https://bz.apache.org/ooo/attachment.cgi?id=84515&action=edit
Patch to change ifndef statements to ifdef in this makefile.
Operating environment: openSUSE 12.3
GNU Make 3.82
ifndef conditions in /vcl/Module_vcl.mk not processed.
Even though --enable-gtk specified, gtk plugin not built. Porecessing of --
ifneq ($(ENABLE_GTK),)
construct seems to be non-operable with current GNU make version of 3.82.
Patch to change the logic for this statement and similar for KDE statements.
Only the GTK option has been built and verified that vcl-gtk plugin is now
being built.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126118] malformed make conditions in /vcl/Module_vcl.mk
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Kay <ks...@apache.org> ---
Changes committed with rev 1667884
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126118] malformed make conditions in /vcl/Module_vcl.mk
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #84515| |review+
Flags| |
--- Comment #1 from Kay <ks...@apache.org> ---
Comment on attachment 84515
--> https://bz.apache.org/ooo/attachment.cgi?id=84515
Patch to change ifndef statements to ifdef in this makefile.
Need review for this patch on all platforms.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126118] malformed make conditions in /vcl/Module_vcl.mk
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #84515|review+ |review?
Flags| |
--- Comment #2 from Kay <ks...@apache.org> ---
Comment on attachment 84515
--> https://bz.apache.org/ooo/attachment.cgi?id=84515
Patch to change ifndef statements to ifdef in this makefile.
set flag incorrectly before. Reset to "request" not granted.
--
You are receiving this mail because:
You are the assignee for the issue.
review requested: [Issue 126118] malformed make conditions in
/vcl/Module_vcl.mk : [Attachment 84515] Patch to change ifndef statements to
ifdef in this makefile.
Posted by bu...@apache.org.
Kay <ks...@apache.org> has asked for review:
Issue 126118: malformed make conditions in /vcl/Module_vcl.mk
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Attachment 84515: Patch to change ifndef statements to ifdef in this makefile.
https://bz.apache.org/ooo/attachment.cgi?id=84515&action=edit
--- Comment #2 from Kay <ks...@apache.org> ---
Comment on attachment 84515
--> https://bz.apache.org/ooo/attachment.cgi?id=84515
Patch to change ifndef statements to ifdef in this makefile.
set flag incorrectly before. Reset to "request" not granted.
[Issue 126118] malformed make conditions in /vcl/Module_vcl.mk
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.2.0
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126118] malformed make conditions in /vcl/Module_vcl.mk
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS|Linux32 |Linux
--
You are receiving this mail because:
You are the assignee for the issue.
review granted: [Issue 126118] malformed make conditions in
/vcl/Module_vcl.mk : [Attachment 84515] Patch to change ifndef statements to
ifdef in this makefile.
Posted by bu...@apache.org.
Kay <ks...@apache.org> has granted review:
Issue 126118: malformed make conditions in /vcl/Module_vcl.mk
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Attachment 84515: Patch to change ifndef statements to ifdef in this makefile.
https://bz.apache.org/ooo/attachment.cgi?id=84515&action=edit
--- Comment #1 from Kay <ks...@apache.org> ---
Comment on attachment 84515
--> https://bz.apache.org/ooo/attachment.cgi?id=84515
Patch to change ifndef statements to ifdef in this makefile.
Need review for this patch on all platforms.
[Issue 126118] malformed make conditions in /vcl/Module_vcl.mk
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126118
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest|--- |4.2.0-dev
Confirmation on| |
CC| |kschenk@apache.org
--
You are receiving this mail because:
You are the assignee for the issue.