You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2013/10/04 11:42:05 UTC
Review Request 14489: Wrong error notification is generated when Primary
storage (Cluster wide) is added with wrong path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14489/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3994
Repository: cloudstack-git
Description
-------
returning false when hostPoolRecords size is zero
Diffs
-----
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java b9b7424
Diff: https://reviews.apache.org/r/14489/diff/
Testing
-------
tested on my local setup
Thanks,
Anshul Gangwar
Re: Review Request 14489: Wrong error notification is generated when Primary
storage (Cluster wide) is added with wrong path
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14489/
-----------------------------------------------------------
(Updated Oct. 4, 2013, 10:17 a.m.)
Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
Changes
-------
added the branch for patch
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3994
Repository: cloudstack-git
Description
-------
returning false when hostPoolRecords size is zero
Diffs
-----
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java b9b7424
Diff: https://reviews.apache.org/r/14489/diff/
Testing
-------
tested on my local setup
Thanks,
Anshul Gangwar
Re: Review Request 14489: Wrong error notification is generated when Primary
storage (Cluster wide) is added with wrong path
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14489/#review26668
-----------------------------------------------------------
Ship it!
Looks good to me.
- Rajesh Battala
On Oct. 4, 2013, 9:43 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14489/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2013, 9:43 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3994
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> returning false when hostPoolRecords size is zero
>
>
> Diffs
> -----
>
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java b9b7424
>
> Diff: https://reviews.apache.org/r/14489/diff/
>
>
> Testing
> -------
>
> tested on my local setup
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 14489: Wrong error notification is generated when Primary
storage (Cluster wide) is added with wrong path
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14489/
-----------------------------------------------------------
(Updated Oct. 4, 2013, 9:43 a.m.)
Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
Changes
-------
adding Rajesh ...
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3994
Repository: cloudstack-git
Description
-------
returning false when hostPoolRecords size is zero
Diffs
-----
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java b9b7424
Diff: https://reviews.apache.org/r/14489/diff/
Testing
-------
tested on my local setup
Thanks,
Anshul Gangwar