You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "EternalDeiwos (via GitHub)" <gi...@apache.org> on 2023/09/10 10:54:26 UTC
[GitHub] [iceberg] EternalDeiwos opened a new pull request, #8543: Core: Refactor RestCatalogAdapter to use existing HttpMethod enum
EternalDeiwos opened a new pull request, #8543:
URL: https://github.com/apache/iceberg/pull/8543
While attempting to extend the `RestCatalogAdapter` class I found this was quite difficult to do because the `HTTPMethod` is not public. I can't easily extend the `execute` method because it consumes that type.
First I thought that I could just make that enum public, however then I found that an enum for this already exists at `org.apache.iceberg.rest.HttpMethod`, although it does have fields `usesResponseBody` and `usesRequestBody` which are unused in this case. I thought that reusing something that already exists would be better than polluting the namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Refactor RestCatalogAdapter to use existing HttpMethod enum [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8543:
URL: https://github.com/apache/iceberg/pull/8543#issuecomment-2378157109
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] EternalDeiwos commented on pull request #8543: Core: Refactor RestCatalogAdapter to use existing HttpMethod enum
Posted by "EternalDeiwos (via GitHub)" <gi...@apache.org>.
EternalDeiwos commented on PR #8543:
URL: https://github.com/apache/iceberg/pull/8543#issuecomment-1714244738
@rdblue I plan on using it exactly like [this](https://github.com/tabular-io/iceberg-rest-image/blob/0d900c90fc8874594643c00cdc77da822e151528/src/main/java/org/apache/iceberg/rest/RESTCatalogServer.java#L87) but with an override to the `execute` method to send requests to OPA for authentication/authorization before passing control back to `super`.
I realize the class in question is for testing purposes, however for my (and possibly other’s) PoCs it would suffice for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #8543: Core: Refactor RestCatalogAdapter to use existing HttpMethod enum
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #8543:
URL: https://github.com/apache/iceberg/pull/8543#issuecomment-1714118948
@EternalDeiwos, what are you trying to do with `RESTCatalogAdapter`? That's an internal class used for testing and isn't intended for anything else. The useful implementation parts are available in `CatalogHandlers` if you want to build your own REST catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Refactor RestCatalogAdapter to use existing HttpMethod enum [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8543: Core: Refactor RestCatalogAdapter to use existing HttpMethod enum
URL: https://github.com/apache/iceberg/pull/8543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Refactor RestCatalogAdapter to use existing HttpMethod enum [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8543:
URL: https://github.com/apache/iceberg/pull/8543#issuecomment-2362460050
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org