[jira] Updated: (BEEHIVE-776) exception-handled event not raised for locally defined handler

["Rich Feit (JIRA)" <be...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/BEEHIVE-776?page=all ]

Rich Feit updated BEEHIVE-776:
------------------------------

    Description: 
I've haven't been able to see the exception-handled event raised by the DefaultPageFlowEventReporter.  I do see the exception-raised event, and I see the handler run in the PageFlow.  When I step  through in the debugger, I think I see a spot where we return from DefaultExceptionsHandler.handleException() method without calling exceptionHandled().  See <DR> below.  

...
if ( exceptionConfig instanceof PageFlowExceptionConfig )
{
  PageFlowExceptionConfig pfExceptionConfig = ( PageFlowExceptionConfig ) exceptionConfig;
                
  if ( pfExceptionConfig.isHandlerMethod() )
  {
    // <DR> We return here without calling the event reporter
    return invokeExceptionHandlerMethod( context, ex, pfExceptionConfig, form, actionMapping );
  }
}
            
ActionForward ret =
   invokeExceptionHandlerClass( context, ex, exceptionConfig, actionMapping, form );
// Callback to the event reporter.
long timeTaken = System.currentTimeMillis() - startTime;
_eventReporter.exceptionHandled( ex, actionMapping, form, flowController, request, response, ret, timeTaken );


  was:

I've haven't been able to see the exception-handled event raised by the DefaultPageFlowEventReporter.  I do see the exception-raised event, and I see the handler run in the PageFlow.  When I step  through in the debugger, I think I see a spot where we return from DefaultExceptionsHandler.handleException() method without calling exceptionHandled().  See <DR> below.  

...
if ( exceptionConfig instanceof PageFlowExceptionConfig )
{
  PageFlowExceptionConfig pfExceptionConfig = ( PageFlowExceptionConfig ) exceptionConfig;
                
  if ( pfExceptionConfig.isHandlerMethod() )
  {
    // <DR> We return here without calling the event reporter
    return invokeExceptionHandlerMethod( context, ex, pfExceptionConfig, form, actionMapping );
  }
}
            
ActionForward ret =
   invokeExceptionHandlerClass( context, ex, exceptionConfig, actionMapping, form );
// Callback to the event reporter.
long timeTaken = System.currentTimeMillis() - startTime;
_eventReporter.exceptionHandled( ex, actionMapping, form, flowController, request, response, ret, timeTaken );


       Priority: Major  (was: Minor)

Ouch -- the logic that's at the bottom should also be there for the handler-method case.  I feel like this is Major, since handler-methods are the main case for page flows.

> exception-handled event not raised for locally defined handler
> --------------------------------------------------------------
>
>          Key: BEEHIVE-776
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-776
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1
>  Environment: windows-XP
>     Reporter: David Read
>     Assignee: Rich Feit
>      Fix For: TBD

>
> I've haven't been able to see the exception-handled event raised by the DefaultPageFlowEventReporter.  I do see the exception-raised event, and I see the handler run in the PageFlow.  When I step  through in the debugger, I think I see a spot where we return from DefaultExceptionsHandler.handleException() method without calling exceptionHandled().  See <DR> below.  
> ...
> if ( exceptionConfig instanceof PageFlowExceptionConfig )
> {
>   PageFlowExceptionConfig pfExceptionConfig = ( PageFlowExceptionConfig ) exceptionConfig;
>                 
>   if ( pfExceptionConfig.isHandlerMethod() )
>   {
>     // <DR> We return here without calling the event reporter
>     return invokeExceptionHandlerMethod( context, ex, pfExceptionConfig, form, actionMapping );
>   }
> }
>             
> ActionForward ret =
>    invokeExceptionHandlerClass( context, ex, exceptionConfig, actionMapping, form );
> // Callback to the event reporter.
> long timeTaken = System.currentTimeMillis() - startTime;
> _eventReporter.exceptionHandled( ex, actionMapping, form, flowController, request, response, ret, timeTaken );

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira