You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/12 11:38:02 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #25670: Fix `airflow-github needs-categorization` tool handling of renamed files

potiuk commented on code in PR #25670:
URL: https://github.com/apache/airflow/pull/25670#discussion_r944379085


##########
dev/airflow-github:
##########
@@ -173,6 +173,9 @@ def is_core_commit(files: List[str]) -> bool:
         for ignore in non_core_files:
             if file.startswith(ignore):
                 break
+            # Handle renaming. Form: {old_name} -> {new_name}
+            elif file.startswith("{") and file[1:].startswith(ignore):

Review Comment:
   good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org