You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/04/20 06:20:18 UTC

[GitHub] flink pull request #5882: [FLINK-9223] bufferConsumers should be closed in S...

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5882

    [FLINK-9223] bufferConsumers should be closed in SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd

    ## What is the purpose of the change
    
    *This pull request closes buffer consumers in SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd after operation has done*
    
    
    ## Brief change log
    
      - *Call close method after operation on bufferConsumers is done*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-9223

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5882.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5882
    
----
commit 6c4608857b5450493c24c1b77df0e6665dfc2725
Author: yanghua <ya...@...>
Date:   2018-04-20T06:11:45Z

    [FLINK-9223] bufferConsumers should be closed in SpillableSubpartitionTest#testConsumeSpilledPartitionSpilledBeforeAdd

----


---

[GitHub] flink issue #5882: [FLINK-9223] bufferConsumers should be closed in Spillabl...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5882
  
    Looks good, thanks!
    
    Will merge this in the next batch...


---

[GitHub] flink pull request #5882: [FLINK-9223] bufferConsumers should be closed in S...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5882


---

[GitHub] flink issue #5882: [FLINK-9223] bufferConsumers should be closed in Spillabl...

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5882
  
    cc @tillrohrmann 


---