You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/09 11:39:44 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #21425: Support select intersect, except statement in sql federation and refactor combine operator parse
strongduanmu opened a new pull request, #21425:
URL: https://github.com/apache/shardingsphere/pull/21425
Fixes #21420.
Changes proposed in this pull request:
- support select intersect, except statement in sql federation
- refactor combine operator parse
- add unit test
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21425: Support select intersect, except statement in sql federation and refactor combine operator parse
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21425:
URL: https://github.com/apache/shardingsphere/pull/21425#issuecomment-1272532378
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21425](https://codecov.io/gh/apache/shardingsphere/pull/21425?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46fd0f3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/40b5076d63d21c0bb19cca16d4db211648b3c7f5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (40b5076) will **decrease** coverage by `0.05%`.
> The diff coverage is `69.76%`.
```diff
@@ Coverage Diff @@
## master #21425 +/- ##
============================================
- Coverage 61.55% 61.49% -0.06%
- Complexity 2508 2509 +1
============================================
Files 4097 4097
Lines 56718 56761 +43
Branches 7493 7501 +8
============================================
- Hits 34912 34908 -4
- Misses 18882 18927 +45
- Partials 2924 2926 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sharding/decider/ShardingSQLFederationDecider.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZGVjaWRlci9TaGFyZGluZ1NRTEZlZGVyYXRpb25EZWNpZGVyLmphdmE=) | `71.42% <ø> (ø)` | |
| [...a/binder/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `69.91% <0.00%> (ø)` | |
| [...ql/parser/sql/common/extractor/TableExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9leHRyYWN0b3IvVGFibGVFeHRyYWN0b3IuamF2YQ==) | `20.24% <0.00%> (ø)` | |
| [...erts/statement/dml/impl/SelectStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2RtbC9pbXBsL1NlbGVjdFN0YXRlbWVudEFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../domain/statement/dml/SelectStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2pheGIvY2FzZXMvZG9tYWluL3N0YXRlbWVudC9kbWwvU2VsZWN0U3RhdGVtZW50VGVzdENhc2UuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...sitor/statement/impl/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9kaWFsZWN0L215c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL215c3FsL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvTXlTUUxTdGF0ZW1lbnRTUUxWaXNpdG9yLmphdmE=) | `87.81% <60.00%> (-0.21%)` | :arrow_down: |
| [...on/optimizer/converter/SQLNodeConverterEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL29wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvY29udmVydGVyL1NRTE5vZGVDb252ZXJ0ZXJFbmdpbmUuamF2YQ==) | `83.33% <100.00%> (+11.90%)` | :arrow_up: |
| [...mizer/converter/type/CombineOperatorConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL29wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvY29udmVydGVyL3R5cGUvQ29tYmluZU9wZXJhdG9yQ29udmVydGVyLmphdmE=) | `93.33% <100.00%> (+1.02%)` | :arrow_up: |
| [...ation/optimizer/util/SQLFederationPlannerUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NxbC1mZWRlcmF0aW9uL29wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsZmVkZXJhdGlvbi9vcHRpbWl6ZXIvdXRpbC9TUUxGZWRlcmF0aW9uUGxhbm5lclV0aWwuamF2YQ==) | `97.50% <100.00%> (-0.31%)` | :arrow_down: |
| [...r/statement/impl/OpenGaussStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9kaWFsZWN0L29wZW5nYXVzcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9vcGVuZ2F1c3MvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9PcGVuR2F1c3NTdGF0ZW1lbnRTUUxWaXNpdG9yLmphdmE=) | `85.69% <100.00%> (+0.07%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/shardingsphere/pull/21425/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #21425: Support select intersect, except statement in sql federation and refactor combine operator parse
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21425:
URL: https://github.com/apache/shardingsphere/pull/21425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org