You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ni...@apache.org on 2021/11/22 18:11:49 UTC

[cordova-coho] branch vote-checklist updated: second draft

This is an automated email from the ASF dual-hosted git repository.

niklasmerz pushed a commit to branch vote-checklist
in repository https://gitbox.apache.org/repos/asf/cordova-coho.git


The following commit(s) were added to refs/heads/vote-checklist by this push:
     new a90b1c5  second draft
a90b1c5 is described below

commit a90b1c57b04164b5eaa215ce57b7f127f6697ce4
Author: Niklas Merz <ni...@apache.org>
AuthorDate: Mon Nov 22 19:11:00 2021 +0100

    second draft
    
    Co-authored-by: エリス <er...@users.noreply.github.com>
---
 docs/vote-checklist.md | 38 +++++++++++++++++++++++++++-----------
 1 file changed, 27 insertions(+), 11 deletions(-)

diff --git a/docs/vote-checklist.md b/docs/vote-checklist.md
index a283324..d092c0d 100644
--- a/docs/vote-checklist.md
+++ b/docs/vote-checklist.md
@@ -1,20 +1,36 @@
 # Checklist for relase voting
 
-This is just a short checklist of things to check when voting for a release. Please follow the [release voting guide](./release-voting.md) first.
+Here is a short checklist when voting for a release. Please follow the [release voting guide](./release-voting.md) first.
 
-You can do this with or without coho.
+First we need the information in the VOTE E-mail and dowload all files.
+
+**With coho:**
 
-1. Download files from E-mail
 1. Verify signature (`coho verify-archive FILENAME`, `gpg --verify FILENAME.asc`)
 1. Verify hash (`coho verify-archive FILENAME`)
-1. Untar package (`tar -xf FILENAME`)
-1. Check version (version from release, no -dev suffix)
-1. Check release notes (release notes for current release exist)
-1. Check cordova engine (`engines.cordovaDependencies.CURRENTVERSION` in package.json does not have `>100`)
-1. Check license file (license file with Apache license exists)
-1. Clone/update git repo
+
+**Without coho:**
+
+1. Untar the package (`tar -xf FILENAME`)
+  1. Check version (version from release, no -dev suffix)
+  1. Check release notes (release notes for current release exist)
+  1. Check license file (license file with Apache license exists)
+
+## With the git repo upstream
+
+Before continuing, we must first fetch and pull the latest changes from the repo that is being voted on and then switch to the release draft tag.
+
+**With coho:**
+
 1. Check tag with hash from E-mail (`coho verify-tags` in repository in ~/apache directory)
+1. Check license headers (all source code files need Apache license header, Apache Rat helps, `coho audit-license-headers` in repository in ~/apache directory)
+1. Check dependencies (npm dependencies need to be licensed with a compatible license, `coho check-license` in repository in ~/apache directory)
+
+**Without coho:**
+
 1. Run tests
 1. npm audit
-1. Check license headers (all source code files need Apache license header, Apache Rat helps, `coho audit-license-headers` in repository in ~/apache directory)
-1. Check dependencies (npm dependencies need to be licensed with a compatible license, `coho check-license` in repository in ~/apache directory)
\ No newline at end of file
+
+*Special Case for Plugins:*
+
+1. Check cordova engine (`engines.cordovaDependencies.CURRENTVERSION` in package.json does not have `>100`)
\ No newline at end of file

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org