[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16165: [improve][client] [PIP-165] Auto release client useless connections

[GitBox <gi...@apache.org>]

poorbarcode commented on code in PR #16165:
URL: https://github.com/apache/pulsar/pull/16165#discussion_r905845580


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -1203,9 +1203,9 @@ private void checkRequestTimeout() {
     private static final Logger log = LoggerFactory.getLogger(ClientCnx.class);
 
     /**
-     * Check client connection is now free. This method may change the state to idle.
-     * This method will not change the state to idle.
-     * @return this connection is idle now.
+     * Check if the client connection is eligible for being marked as idle. 

Review Comment:
   Hi @gaozhangmin 
   src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:[1206] (regexp) RegexpSingleline: Trailing whitespace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org