You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/11/04 15:58:11 UTC
[GitHub] incubator-zeppelin pull request: Hot Fix - Remove Karma coverage
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/390
Hot Fix - Remove Karma coverage
There has been a few karma issues during build, after trying it today I realized that running ``./grunt test`` wasn't really showing the usual output.
Some time Before:
<img width="697" alt="screen shot 2015-11-04 at 11 50 34 pm" src="https://cloud.githubusercontent.com/assets/710411/10941613/b557764a-834f-11e5-944d-073a629d35d2.png">
Now:
<img width="704" alt="screen shot 2015-11-04 at 11 51 18 pm" src="https://cloud.githubusercontent.com/assets/710411/10941618/b87c589a-834f-11e5-89da-706eab7aae5b.png">
I'm thinking that Karma coverage might be blocking karma tests and failing from time to time.
I will need a few people who have problems with karma to check it out.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/karmaProblems
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit b7e2b7b33a5d4ac6c648f9d32788612c567707d6
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-04T14:46:36Z
Hot Fix - Remove Karma coverage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Hot Fix - Remove Karma coverage
Posted by rconline <gi...@git.apache.org>.
Github user rconline commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/390#issuecomment-153982076
@corneadoug having coverage is a good idea. We should look at the issue one more time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-431 - Show Karma test re...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/390#issuecomment-157591113
Merging if there is no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-431 - Show Karma test re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Hot Fix - Remove Karma coverage
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/390#issuecomment-153985711
@rconline right, feedbacks I got from others is that this is not fixing their problems.
So this won't be merged.
But I would sacrifice the test coverage plugin of the webapp anytime if it was making the build more stable. (Since we are not yet using that test coverage generated anywhere)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-431 - Show Karma test re...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/390#issuecomment-157247769
Just changed the scope of this PR, it is now ready to be merged.
Code coverage is still there, although the report path changed from inside ``zeppelin-web/reports/coverage`` to ``incubator-zeppelin/reports/zeppelin-web-coverage``.
And the tests results are now showing again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---