[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3555: User compaction not retried after failure

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3555:
URL: https://github.com/apache/accumulo/pull/3555#discussion_r1247223619


##########
test/src/main/java/org/apache/accumulo/test/functional/CompactionIT.java:
##########
@@ -280,6 +280,27 @@ public void testUserCompactionCancellation() throws Exception {
     }
   }
 
+  @Test
+  public void testErrorDuringUserCompaction() throws Exception {
+    final String table1 = this.getUniqueNames(1)[0];
+    try (AccumuloClient client = Accumulo.newClient().from(getClientProps()).build()) {
+      client.tableOperations().create(table1);
+      try (BatchWriter bw = client.createBatchWriter(table1)) {
+        for (int i = 1; i <= MAX_DATA; i++) {
+          Mutation m = new Mutation(Integer.toString(i));
+          m.put("cf", "cq", new Value());
+          bw.addMutation(m);
+          bw.flush();
+          client.tableOperations().flush(table1, null, null, true);
+        }
+      }

Review Comment:
   Do you need to flush the table for every mutation? Are you trying to create separate files for each mutation? If so, this could use a comment. Otherwise, this can be simplified:
   
   ```suggestion
           }
         }
         client.tableOperations().flush(table1, null, null, true);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org