You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lvyanquan (via GitHub)" <gi...@apache.org> on 2023/03/16 09:45:00 UTC
[GitHub] [hudi] lvyanquan opened a new pull request, #8202: [MINOR][DOC] Fix typo in ValidateMetadataTableFilesProcedure
lvyanquan opened a new pull request, #8202:
URL: https://github.com/apache/hudi/pull/8202
### Change Logs
Fix typo in ValidateMetadataTableFilesProcedure
### Impact
The program that reads this field directly needs to be modified, but this sql does not exist in the current document and is not commonly used
### Risk level (write none, low medium or high below)
low
### Documentation Update
**https://github.com/apache/hudi/pull/8004** should be updated if this pr is merged.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lvyanquan commented on a diff in pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on code in PR #8202:
URL: https://github.com/apache/hudi/pull/8202#discussion_r1138510727
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ValidateMetadataTableFilesProcedure.scala:
##########
@@ -44,7 +44,7 @@ class ValidateMetadataTableFilesProcedure() extends BaseProcedure with Procedure
StructField("partition", DataTypes.StringType, nullable = true, Metadata.empty),
StructField("file_name", DataTypes.StringType, nullable = true, Metadata.empty),
StructField("is_present_in_fs", DataTypes.BooleanType, nullable = true, Metadata.empty),
- StructField("is_resent_in_metadata", DataTypes.BooleanType, nullable = true, Metadata.empty),
+ StructField("is_present_in_metadata", DataTypes.BooleanType, nullable = true, Metadata.empty),
Review Comment:
This is the header of result set. Modify the wrong English spelling to better understand.
There are no test cases here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8202:
URL: https://github.com/apache/hudi/pull/8202#issuecomment-1473523636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750",
"triggerID" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"triggerType" : "PUSH"
}, {
"hash" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15768",
"triggerID" : "1473264500",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0f787f7cca4909e4fff3b8690bf6488355e059d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15768)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8202:
URL: https://github.com/apache/hudi/pull/8202#issuecomment-1471705593
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750",
"triggerID" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0f787f7cca4909e4fff3b8690bf6488355e059d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8202:
URL: https://github.com/apache/hudi/pull/8202#issuecomment-1471694399
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0f787f7cca4909e4fff3b8690bf6488355e059d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8202:
URL: https://github.com/apache/hudi/pull/8202#issuecomment-1472098048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750",
"triggerID" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0f787f7cca4909e4fff3b8690bf6488355e059d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8202:
URL: https://github.com/apache/hudi/pull/8202#issuecomment-1473264500
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8202:
URL: https://github.com/apache/hudi/pull/8202#issuecomment-1473297291
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750",
"triggerID" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"triggerType" : "PUSH"
}, {
"hash" : "d0f787f7cca4909e4fff3b8690bf6488355e059d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15768",
"triggerID" : "1473264500",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d0f787f7cca4909e4fff3b8690bf6488355e059d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15750) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15768)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8202:
URL: https://github.com/apache/hudi/pull/8202#discussion_r1138445124
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ValidateMetadataTableFilesProcedure.scala:
##########
@@ -44,7 +44,7 @@ class ValidateMetadataTableFilesProcedure() extends BaseProcedure with Procedure
StructField("partition", DataTypes.StringType, nullable = true, Metadata.empty),
StructField("file_name", DataTypes.StringType, nullable = true, Metadata.empty),
StructField("is_present_in_fs", DataTypes.BooleanType, nullable = true, Metadata.empty),
- StructField("is_resent_in_metadata", DataTypes.BooleanType, nullable = true, Metadata.empty),
+ StructField("is_present_in_metadata", DataTypes.BooleanType, nullable = true, Metadata.empty),
Review Comment:
Are there any tests for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8202: [MINOR] Fix typo in ValidateMetadataTableFilesProcedure
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8202:
URL: https://github.com/apache/hudi/pull/8202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org