You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by Bin Shi <bi...@gmail.com> on 2018/09/20 22:43:24 UTC
Re: [jira] [Commented] (PHOENIX-4008) UPDATE STATISTIC should collect
all versions of cells
Hi, the community
I checked the following two test failures, they even failed in my clean
local repository (just cloned from master without any local changes). Any
suggestions?
Test Result
<https://builds.apache.org/job/PreCommit-PHOENIX-Build/2050/testReport/> (2
failures / ±0)
-
org.apache.phoenix.end2end.ConcurrentMutationsIT.testRowLockDuringPreBatchMutateWhenIndexed
<https://builds.apache.org/job/PreCommit-PHOENIX-Build/2050/testReport/junit/org.apache.phoenix.end2end/ConcurrentMutationsIT/testRowLockDuringPreBatchMutateWhenIndexed/>
-
org.apache.phoenix.end2end.ConcurrentMutationsIT.testLockUntilMVCCAdvanced
<https://builds.apache.org/job/PreCommit-PHOENIX-Build/2050/testReport/junit/org.apache.phoenix.end2end/ConcurrentMutationsIT/testLockUntilMVCCAdvanced/>
Thanks,
*Bin Shi **LinkedIn <https://www.linkedin.com/in/bin-shi-63a118108/>*
PMTS | Infrastructure Engineering
*Salesforce (Seattle|Bellevue)*
*Cell:* 425-247-4348
*Email: *bshi@salesforce.com
On Thu, Sep 20, 2018 at 3:07 PM Hadoop QA (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/PHOENIX-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622782#comment-16622782
> ]
>
> Hadoop QA commented on PHOENIX-4008:
> ------------------------------------
>
> {color:red}-1 overall{color}. Here are the results of testing the latest
> attachment
>
> http://issues.apache.org/jira/secure/attachment/12940630/PHOENIX-4008_0920.patch
> against master branch at commit 91f085a902357b0a589b6367fb9c5f40b9781c8f.
> ATTACHMENT ID: 12940630
>
> {color:green}+1 @author{color}. The patch does not contain any
> @author tags.
>
> {color:red}-1 tests included{color}. The patch doesn't appear to
> include any new or modified tests.
> Please justify why no new tests are needed for
> this patch.
> Also please list what manual steps were performed
> to verify this patch.
>
> {color:green}+1 javac{color}. The applied patch does not increase the
> total number of javac compiler warnings.
>
> {color:green}+1 release audit{color}. The applied patch does not
> increase the total number of release audit warnings.
>
> {color:red}-1 lineLengths{color}. The patch introduces the following
> lines longer than 100:
> + new
> GuidePostsKey(Bytes.toBytes(tableName), Bytes.toBytes(familyName)),
> + assertTrue(emptyGuidePostExpected ?
> gps.isEmptyGuidePost() : !gps.isEmptyGuidePost());
> + verifyGuidePostGenerated(queryServices, tableName, new
> String[] {"C1", "C2"}, guidePostWidth, true);
> + "CREATE TABLE " + tableName + " (k INTEGER PRIMARY
> KEY, c1.a bigint, c2.b bigint)"
> + // The table only has one row. All cells just has one
> version, and the data size of the row
> + verifyGuidePostGenerated(queryServices, tableName, new
> String[] {"C1", "C2"}, guidePostWidth, true);
> + verifyGuidePostGenerated(queryServices, tableName, new
> String[] {"C1", "C2"}, guidePostWidth, false);
>
> {color:red}-1 core tests{color}. The patch failed these unit tests:
>
> ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
>
> Test results:
> https://builds.apache.org/job/PreCommit-PHOENIX-Build/2050//testReport/
> Console output:
> https://builds.apache.org/job/PreCommit-PHOENIX-Build/2050//console
>
> This message is automatically generated.
>
> > UPDATE STATISTIC should collect all versions of cells
> > -----------------------------------------------------
> >
> > Key: PHOENIX-4008
> > URL: https://issues.apache.org/jira/browse/PHOENIX-4008
> > Project: Phoenix
> > Issue Type: Bug
> > Reporter: Samarth Jain
> > Assignee: Bin Shi
> > Priority: Major
> > Attachments: PHOENIX-4008_0918.patch, PHOENIX-4008_0920.patch
> >
> >
> > In order to truly measure the size of data when calculating guide posts,
> UPDATE STATISTIC should taken into account all versions of cells. We should
> also be setting the max versions on the scan.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>