You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/14 17:26:05 UTC

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #368: Add schema logic in producer and consumer

cckellogg commented on a change in pull request #368:
URL: https://github.com/apache/pulsar-client-go/pull/368#discussion_r504847055



##########
File path: pulsar/schemaDef_test.go
##########
@@ -0,0 +1,57 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       we should be consistent with name. all the files are snake_case and I suggest we keep it that way for consistency. schema_def_test.go. Same for the other files in the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org