You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/25 23:43:17 UTC
[GitHub] [pulsar] lhotari opened a new pull request #8706: Upgrade license-maven-plugin to 4.0.rc2 version
lhotari opened a new pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706
### Motivation
Keep [license-maven-plugin](https://mycila.mathieu.photography/license-maven-plugin/) updated.
### Modifications
Adapt existing configuration from 3.0 to 4.0.rc2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#discussion_r530813102
##########
File path: pom.xml
##########
@@ -200,7 +200,7 @@ flexible messaging model and an intuitive client API.</description>
<protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<aspectj-maven-plugin.version>1.11.1</aspectj-maven-plugin.version>
- <license-maven-plugin.version>3.0</license-maven-plugin.version>
+ <license-maven-plugin.version>4.0.rc2</license-maven-plugin.version>
Review comment:
3.0 was released in August 2016, so that's one of the reasons to get on 4.0.rc2 which was release in August 2020. I wouldn't be concerned that it's a rc version. The commit history of license-maven-plugin can be viewed at https://github.com/mycila/license-maven-plugin . It seems that there are quite a few fixes included in 4.0.rc2 compared to 3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#discussion_r531692073
##########
File path: pom.xml
##########
@@ -200,7 +200,7 @@ flexible messaging model and an intuitive client API.</description>
<protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<aspectj-maven-plugin.version>1.11.1</aspectj-maven-plugin.version>
- <license-maven-plugin.version>3.0</license-maven-plugin.version>
+ <license-maven-plugin.version>4.0.rc2</license-maven-plugin.version>
Review comment:
Since this is a dev tool and not a runtime dependency, I don't see any issue to upgrade to an RC version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#discussion_r530716246
##########
File path: pom.xml
##########
@@ -200,7 +200,7 @@ flexible messaging model and an intuitive client API.</description>
<protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<aspectj-maven-plugin.version>1.11.1</aspectj-maven-plugin.version>
- <license-maven-plugin.version>3.0</license-maven-plugin.version>
+ <license-maven-plugin.version>4.0.rc2</license-maven-plugin.version>
Review comment:
I wonder to know should we use a stable version for that? `rc` seems it is not a stable version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#issuecomment-734451140
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#issuecomment-734162698
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#discussion_r530716246
##########
File path: pom.xml
##########
@@ -200,7 +200,7 @@ flexible messaging model and an intuitive client API.</description>
<protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<aspectj-maven-plugin.version>1.11.1</aspectj-maven-plugin.version>
- <license-maven-plugin.version>3.0</license-maven-plugin.version>
+ <license-maven-plugin.version>4.0.rc2</license-maven-plugin.version>
Review comment:
Just curious, I wonder to know should we use a stable version for that? `rc` seems it is not a stable version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8706: [build] Upgrade license-maven-plugin to 4.0.rc2 version
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8706:
URL: https://github.com/apache/pulsar/pull/8706#issuecomment-734413593
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org