[GitHub] [beam] y1chi commented on a change in pull request #13421: [BEAM-9602] Add timer family support for python SDK

[GitBox <gi...@apache.org>]

y1chi commented on a change in pull request #13421:
URL: https://github.com/apache/beam/pull/13421#discussion_r535476915



##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -643,15 +643,16 @@ def commit(self):
 
 class OutputTimer(userstate.BaseTimer):
   def __init__(self,
+               dynamic_timer_tag,  # type: str
                key,
-               window,  # type: windowed_value.BoundedWindow
+               window,  # type: BoundedWindow
                timestamp,  # type: timestamp.Timestamp
                paneinfo,  # type: windowed_value.PaneInfo
                time_domain, # type: str
                timer_family_id,  # type: str
                timer_coder_impl,  # type: coder_impl.TimerCoderImpl
-               output_stream  # type: data_plane.ClosableOutputStream
-              ):
+               output_stream,  # type: data_plane.ClosableOutputStream

Review comment:
       removed.

##########
File path: sdks/python/apache_beam/transforms/userstate.py
##########
@@ -188,15 +190,14 @@ def to_runner_api(self, context, key_coder, window_coder):
 class TimerFamilySpec(object):

Review comment:
       done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org