You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/23 19:41:03 UTC
[GitHub] [beam] pabloem opened a new pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
pabloem opened a new pull request #11509:
URL: https://github.com/apache/beam/pull/11509
The issue occurs here: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery_file_loads.py#L333-L346
In line 343, the `tableId` for the job destination is replaced. Because parse_table_reference does not create a new object, the original object is overwritten, and thus copy jobs are issued from temp_table to temp_table instead of being issued from temp_table to final_table.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11509:
URL: https://github.com/apache/beam/pull/11509#discussion_r414087468
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -182,7 +182,10 @@ def parse_table_reference(table, dataset=None, project=None):
"""
if isinstance(table, bigquery.TableReference):
- return table
+ return bigquery.TableReference(
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11509:
URL: https://github.com/apache/beam/pull/11509#discussion_r414091223
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -182,7 +182,10 @@ def parse_table_reference(table, dataset=None, project=None):
"""
if isinstance(table, bigquery.TableReference):
- return table
+ return bigquery.TableReference(
Review comment:
Ah... ok.. I can do that second option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #11509:
URL: https://github.com/apache/beam/pull/11509#discussion_r414082018
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -182,7 +182,10 @@ def parse_table_reference(table, dataset=None, project=None):
"""
if isinstance(table, bigquery.TableReference):
- return table
+ return bigquery.TableReference(
Review comment:
Probably update the spec above to mention that a new object will be returned ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11509:
URL: https://github.com/apache/beam/pull/11509#discussion_r414099291
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -182,7 +182,10 @@ def parse_table_reference(table, dataset=None, project=None):
"""
if isinstance(table, bigquery.TableReference):
- return table
+ return bigquery.TableReference(
Review comment:
on second thought, I think it's a better practice to avoid reusing objects, and create copies for clarity...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11509:
URL: https://github.com/apache/beam/pull/11509#issuecomment-618621500
Run Python 3.6 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #11509:
URL: https://github.com/apache/beam/pull/11509#discussion_r414083600
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -182,7 +182,10 @@ def parse_table_reference(table, dataset=None, project=None):
"""
if isinstance(table, bigquery.TableReference):
- return table
+ return bigquery.TableReference(
Review comment:
Another option might be to create a new object at line 343 which might be cleaner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #11509: [BEAM-9812] Fixing bug causing pipelines requiring temp tables to not work
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #11509:
URL: https://github.com/apache/beam/pull/11509#issuecomment-618631669
running 3.6 PC: https://builds.apache.org/job/beam_PostCommit_Python36_PR/62/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org