You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by W4anD0eR96 <gi...@git.apache.org> on 2018/05/07 03:19:04 UTC

[GitHub] flink pull request #5957: [hotfix][doc] Synchronize Quickstart with the late...

GitHub user W4anD0eR96 opened a pull request:

    https://github.com/apache/flink/pull/5957

    [hotfix][doc] Synchronize Quickstart with the latest SNAPSHOT

    ## What is the purpose of the change
    
    Our Quickstart page is a little out of date, this pull request is to keep it synchronized with the latest SNAPSHOT.
    
    ## Brief change log
    
    - Modify print log command with new log filename.
    - Remove leading whitespaces to trim them in highlight block.
    - Correct the command to stop Flink
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/W4anD0eR96/flink patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5957
    
----
commit d7cb4e7e174a953d0fc5509f2509df699a4945a6
Author: 陈梓立 <wa...@...>
Date:   2018-05-07T03:10:54Z

    [hotfix][doc] Synchronize Quickstart with latest SNAPSHOT

----


---

[GitHub] flink pull request #5957: [hotfix][doc] Synchronize Quickstart with the late...

Posted by W4anD0eR96 <gi...@git.apache.org>.
Github user W4anD0eR96 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5957#discussion_r186373455
  
    --- Diff: docs/quickstart/setup_quickstart.md ---
    @@ -233,29 +239,17 @@ window of processing time, as long as words are floating in.
     
     * First of all, we use **netcat** to start local server via
     
    -  {% highlight bash %}
    -  $ nc -l 9000
    -  {% endhighlight %}
    +{% highlight bash %}
    +$ nc -l 9000
    +{% endhighlight %}
     
     * Submit the Flink program:
     
    -  {% highlight bash %}
    -  $ ./bin/flink run examples/streaming/SocketWindowWordCount.jar --port 9000
    -
    -  Cluster configuration: Standalone cluster with JobManager at /127.0.0.1:6123
    -  Using address 127.0.0.1:6123 to connect to JobManager.
    -  JobManager web interface address http://127.0.0.1:8081
    -  Starting execution of program
    -  Submitting job with JobID: 574a10c8debda3dccd0c78a3bde55e1b. Waiting for job completion.
    -  Connected to JobManager at Actor[akka.tcp://flink@127.0.0.1:6123/user/jobmanager#297388688]
    -  11/04/2016 14:04:50     Job execution switched to status RUNNING.
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to SCHEDULED
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to DEPLOYING
    -  11/04/2016 14:04:50     Fast TumblingProcessingTimeWindows(5000) of WindowedStream.main(SocketWindowWordCount.java:79) -> Sink: Unnamed(1/1) switched to SCHEDULED
    --- End diff --
    
    At least when I run with commit c8fa8d025684c222582 .
    
    These messages aren't printed in console any more, and they(not exactly the same text) are logged in file `flink-<username>-taskexecutor-0-localhost.log`.
    
    They are printed if I use flink 1.4 latest.


---

[GitHub] flink pull request #5957: [FLINK-9282][doc] Synchronize Quickstart with the ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5957


---

[GitHub] flink issue #5957: [hotfix][doc] Synchronize Quickstart with the latest SNAP...

Posted by W4anD0eR96 <gi...@git.apache.org>.
Github user W4anD0eR96 commented on the issue:

    https://github.com/apache/flink/pull/5957
  
    cc @zentol @tzulitai 


---

[GitHub] flink issue #5957: [FLINK-9282][doc] Synchronize Quickstart with the latest ...

Posted by W4anD0eR96 <gi...@git.apache.org>.
Github user W4anD0eR96 commented on the issue:

    https://github.com/apache/flink/pull/5957
  
    Thanks!


---

[GitHub] flink issue #5957: [FLINK-9282][doc] Synchronize Quickstart with the latest ...

Posted by W4anD0eR96 <gi...@git.apache.org>.
Github user W4anD0eR96 commented on the issue:

    https://github.com/apache/flink/pull/5957
  
    Ping


---

[GitHub] flink pull request #5957: [FLINK-9282][doc] Synchronize Quickstart with the ...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5957#discussion_r186374883
  
    --- Diff: docs/quickstart/setup_quickstart.md ---
    @@ -233,29 +239,17 @@ window of processing time, as long as words are floating in.
     
     * First of all, we use **netcat** to start local server via
     
    -  {% highlight bash %}
    -  $ nc -l 9000
    -  {% endhighlight %}
    +{% highlight bash %}
    +$ nc -l 9000
    +{% endhighlight %}
     
     * Submit the Flink program:
     
    -  {% highlight bash %}
    -  $ ./bin/flink run examples/streaming/SocketWindowWordCount.jar --port 9000
    -
    -  Cluster configuration: Standalone cluster with JobManager at /127.0.0.1:6123
    -  Using address 127.0.0.1:6123 to connect to JobManager.
    -  JobManager web interface address http://127.0.0.1:8081
    -  Starting execution of program
    -  Submitting job with JobID: 574a10c8debda3dccd0c78a3bde55e1b. Waiting for job completion.
    -  Connected to JobManager at Actor[akka.tcp://flink@127.0.0.1:6123/user/jobmanager#297388688]
    -  11/04/2016 14:04:50     Job execution switched to status RUNNING.
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to SCHEDULED
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to DEPLOYING
    -  11/04/2016 14:04:50     Fast TumblingProcessingTimeWindows(5000) of WindowedStream.main(SocketWindowWordCount.java:79) -> Sink: Unnamed(1/1) switched to SCHEDULED
    --- End diff --
    
    That sounds like a regression and we should probably open a JIRA.


---

[GitHub] flink pull request #5957: [hotfix][doc] Synchronize Quickstart with the late...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5957#discussion_r186351709
  
    --- Diff: docs/quickstart/setup_quickstart.md ---
    @@ -233,29 +239,17 @@ window of processing time, as long as words are floating in.
     
     * First of all, we use **netcat** to start local server via
     
    -  {% highlight bash %}
    -  $ nc -l 9000
    -  {% endhighlight %}
    +{% highlight bash %}
    +$ nc -l 9000
    +{% endhighlight %}
     
     * Submit the Flink program:
     
    -  {% highlight bash %}
    -  $ ./bin/flink run examples/streaming/SocketWindowWordCount.jar --port 9000
    -
    -  Cluster configuration: Standalone cluster with JobManager at /127.0.0.1:6123
    -  Using address 127.0.0.1:6123 to connect to JobManager.
    -  JobManager web interface address http://127.0.0.1:8081
    -  Starting execution of program
    -  Submitting job with JobID: 574a10c8debda3dccd0c78a3bde55e1b. Waiting for job completion.
    -  Connected to JobManager at Actor[akka.tcp://flink@127.0.0.1:6123/user/jobmanager#297388688]
    -  11/04/2016 14:04:50     Job execution switched to status RUNNING.
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to SCHEDULED
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to DEPLOYING
    -  11/04/2016 14:04:50     Fast TumblingProcessingTimeWindows(5000) of WindowedStream.main(SocketWindowWordCount.java:79) -> Sink: Unnamed(1/1) switched to SCHEDULED
    --- End diff --
    
    is this no longer printed?


---

[GitHub] flink issue #5957: [FLINK-9282][doc] Synchronize Quickstart with the latest ...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5957
  
    merging.


---

[GitHub] flink pull request #5957: [FLINK-9282][doc] Synchronize Quickstart with the ...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5957#discussion_r186679634
  
    --- Diff: docs/quickstart/setup_quickstart.md ---
    @@ -233,29 +239,17 @@ window of processing time, as long as words are floating in.
     
     * First of all, we use **netcat** to start local server via
     
    -  {% highlight bash %}
    -  $ nc -l 9000
    -  {% endhighlight %}
    +{% highlight bash %}
    +$ nc -l 9000
    +{% endhighlight %}
     
     * Submit the Flink program:
     
    -  {% highlight bash %}
    -  $ ./bin/flink run examples/streaming/SocketWindowWordCount.jar --port 9000
    -
    -  Cluster configuration: Standalone cluster with JobManager at /127.0.0.1:6123
    -  Using address 127.0.0.1:6123 to connect to JobManager.
    -  JobManager web interface address http://127.0.0.1:8081
    -  Starting execution of program
    -  Submitting job with JobID: 574a10c8debda3dccd0c78a3bde55e1b. Waiting for job completion.
    -  Connected to JobManager at Actor[akka.tcp://flink@127.0.0.1:6123/user/jobmanager#297388688]
    -  11/04/2016 14:04:50     Job execution switched to status RUNNING.
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to SCHEDULED
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to DEPLOYING
    -  11/04/2016 14:04:50     Fast TumblingProcessingTimeWindows(5000) of WindowedStream.main(SocketWindowWordCount.java:79) -> Sink: Unnamed(1/1) switched to SCHEDULED
    --- End diff --
    
    It will be quite difficult to address FLINK-9307 (and probably won't happen before 1.5), so let's merge it as it is.


---

[GitHub] flink pull request #5957: [FLINK-9282][doc] Synchronize Quickstart with the ...

Posted by W4anD0eR96 <gi...@git.apache.org>.
Github user W4anD0eR96 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5957#discussion_r186453573
  
    --- Diff: docs/quickstart/setup_quickstart.md ---
    @@ -233,29 +239,17 @@ window of processing time, as long as words are floating in.
     
     * First of all, we use **netcat** to start local server via
     
    -  {% highlight bash %}
    -  $ nc -l 9000
    -  {% endhighlight %}
    +{% highlight bash %}
    +$ nc -l 9000
    +{% endhighlight %}
     
     * Submit the Flink program:
     
    -  {% highlight bash %}
    -  $ ./bin/flink run examples/streaming/SocketWindowWordCount.jar --port 9000
    -
    -  Cluster configuration: Standalone cluster with JobManager at /127.0.0.1:6123
    -  Using address 127.0.0.1:6123 to connect to JobManager.
    -  JobManager web interface address http://127.0.0.1:8081
    -  Starting execution of program
    -  Submitting job with JobID: 574a10c8debda3dccd0c78a3bde55e1b. Waiting for job completion.
    -  Connected to JobManager at Actor[akka.tcp://flink@127.0.0.1:6123/user/jobmanager#297388688]
    -  11/04/2016 14:04:50     Job execution switched to status RUNNING.
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to SCHEDULED
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to DEPLOYING
    -  11/04/2016 14:04:50     Fast TumblingProcessingTimeWindows(5000) of WindowedStream.main(SocketWindowWordCount.java:79) -> Sink: Unnamed(1/1) switched to SCHEDULED
    --- End diff --
    
    > You are effectively addressing FLINK-9282, could you adjust the PR title and commit message?
    > (There's also another bit that needs an update, see the JIRA.
    
    Done as suggestion.
    
    And file a issue on https://issues.apache.org/jira/browse/FLINK-9307 about suspected regression.


---

[GitHub] flink pull request #5957: [FLINK-9282][doc] Synchronize Quickstart with the ...

Posted by W4anD0eR96 <gi...@git.apache.org>.
Github user W4anD0eR96 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5957#discussion_r186635353
  
    --- Diff: docs/quickstart/setup_quickstart.md ---
    @@ -233,29 +239,17 @@ window of processing time, as long as words are floating in.
     
     * First of all, we use **netcat** to start local server via
     
    -  {% highlight bash %}
    -  $ nc -l 9000
    -  {% endhighlight %}
    +{% highlight bash %}
    +$ nc -l 9000
    +{% endhighlight %}
     
     * Submit the Flink program:
     
    -  {% highlight bash %}
    -  $ ./bin/flink run examples/streaming/SocketWindowWordCount.jar --port 9000
    -
    -  Cluster configuration: Standalone cluster with JobManager at /127.0.0.1:6123
    -  Using address 127.0.0.1:6123 to connect to JobManager.
    -  JobManager web interface address http://127.0.0.1:8081
    -  Starting execution of program
    -  Submitting job with JobID: 574a10c8debda3dccd0c78a3bde55e1b. Waiting for job completion.
    -  Connected to JobManager at Actor[akka.tcp://flink@127.0.0.1:6123/user/jobmanager#297388688]
    -  11/04/2016 14:04:50     Job execution switched to status RUNNING.
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to SCHEDULED
    -  11/04/2016 14:04:50     Source: Socket Stream -> Flat Map(1/1) switched to DEPLOYING
    -  11/04/2016 14:04:50     Fast TumblingProcessingTimeWindows(5000) of WindowedStream.main(SocketWindowWordCount.java:79) -> Sink: Unnamed(1/1) switched to SCHEDULED
    --- End diff --
    
    @zentol Should we await [FLINK-9307](https://issues.apache.org/jira/browse/FLINK-9307) before merge this pull request? Or just revert this section to update quickstart page partly?


---