You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/06/03 17:13:05 UTC
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13500
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Disable cumstom cluster/service FE tests on S3
This patch disables the cumstom cluster/service FE tests when running
against S3, as only S3 FE tests should be ran under such environment.
Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
---
M bin/run-all-tests.sh
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13500/1
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[Impala-ASF-CR] Disable custom cluster/service FE tests on S3
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable custom cluster/service FE tests on S3
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG@7
PS2, Line 7: custom
> typo
Done
http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG@9
PS2, Line 9: custom
> typo
Done
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 21:44:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Disable custom cluster/service FE tests on S3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable custom cluster/service FE tests on S3
......................................................................
Patch Set 3: Verified+1
Only commit message changed so I'll carry verification.
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 00:13:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG@7
PS2, Line 7: cumstom
typo
http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG@9
PS2, Line 9: cumstom
typo
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 21:20:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/3487/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:39:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:16:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable custom cluster/service FE tests on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable custom cluster/service FE tests on S3
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 22:45:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@250
PS1, Line 250: if [[ "$FE_TEST" == true && "${TARGET_FILESYSTEM}" != "s3" ]]; then
> I think it would be better to check if FE_TEST is true. I think we want to
Done
http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@257
PS1, Line 257: fi
> pushd and popd are now mismatched.
Done
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:24:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Thomas Marshall, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13500
to look at the new patch set (#2).
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Disable cumstom cluster/service FE tests on S3
This patch disables the cumstom cluster/service FE tests when running
against S3, as only S3 FE tests should be ran under such environment.
Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
---
M bin/run-all-tests.sh
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13500/2
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3483/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:53:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable custom cluster/service FE tests on S3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable custom cluster/service FE tests on S3
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 00:13:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4390/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:15:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 20:56:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable custom cluster/service FE tests on S3
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Thomas Marshall, Lars Volker, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13500
to look at the new patch set (#3).
Change subject: Disable custom cluster/service FE tests on S3
......................................................................
Disable custom cluster/service FE tests on S3
This patch disables the custom cluster/service FE tests when running
against S3, as only S3 FE tests should be ran under such environment.
Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
---
M bin/run-all-tests.sh
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13500/3
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4392/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 20:57:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
I think the mismatched pushd/popd will cause problems in the S3 case.
http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@250
PS1, Line 250: if [[ "${TARGET_FILESYSTEM}" != "s3" ]]; then
I think it would be better to check if FE_TEST is true. I think we want to skip it for other similar filesystems, e.g. ADLS.
http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@257
PS1, Line 257: popd
pushd and popd are now mismatched.
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:54:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Disable custom cluster/service FE tests on S3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable custom cluster/service FE tests on S3
......................................................................
Disable custom cluster/service FE tests on S3
This patch disables the custom cluster/service FE tests when running
against S3, as only S3 FE tests should be ran under such environment.
Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Reviewed-on: http://gerrit.cloudera.org:8080/13500
Tested-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>