[GitHub] rdhabalia commented on a change in pull request #714: add msgAck and redelivery debug-logs And add topic-name in debug-logs

[gi...@git.apache.org]

rdhabalia commented on a change in pull request #714: add msgAck and redelivery debug-logs And add topic-name in debug-logs
URL: https://github.com/apache/incubator-pulsar/pull/714#discussion_r135077234
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java
 ##########
 @@ -37,13 +37,15 @@
 import org.apache.pulsar.broker.service.Dispatcher;
 import org.apache.pulsar.client.impl.Backoff;
 import org.apache.pulsar.common.api.proto.PulsarApi.CommandSubscribe.SubType;
+import org.apache.pulsar.common.util.Codec;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public final class PersistentDispatcherSingleActiveConsumer extends AbstractDispatcherSingleActiveConsumer implements Dispatcher, ReadEntriesCallback {
 
     private final PersistentTopic topic;
     private final ManagedCursor cursor;
+    private final String name;
 
 Review comment:
   Actually, that's the name of dispatcher which is made of `topicName + cursorName` and we use the same variable-name in other [dispatcher](https://github.com/apache/incubator-pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java#L70) so, I kept the same for naming consistency. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services