You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/24 14:02:17 UTC

[GitHub] [arrow] lidavidm opened a new pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

lidavidm opened a new pull request #12237:
URL: https://github.com/apache/arrow/pull/12237


   ARROW-15373 changed MemoryManager::AllocateBuffer to return
   unique_ptr; the GLib bindings needed updating for this, however.
   Also, tweaked the C++ since some compilers don't implicitly
   convert unique_ptr to shared_ptr on return.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020827832


   Benchmark runs are scheduled for baseline = c76215f3a13155a66bc95caddca47440e7cece65 and contender = 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6. 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/500e4310a15f401e91a33e25266e96f1...0348b6e0de4f4f22857bb6d6422829a5/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/32bad457fae84aeabf87ba4e5200bdfc...4667bb1a09bc44fbac1a9aa92433e132/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa04a0861fa64662b660287c3de225b9...d8b1a5e76f7f406ebedf7ae5d7aa585f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#discussion_r791280678



##########
File path: c_glib/arrow-cuda-glib/cuda.cpp
##########
@@ -288,7 +288,9 @@ garrow_cuda_buffer_new(GArrowCUDAContext *context,
   auto arrow_context = garrow_cuda_context_get_raw(context);
   auto arrow_buffer = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer, "[cuda][buffer][new]")) {
-    return garrow_cuda_buffer_new_raw(&(*arrow_buffer));
+    std::shared_ptr<arrow::cuda::CudaBuffer> cuda_buffer =
+      arrow_buffer.MoveValueUnsafe();
+    return garrow_cuda_buffer_new_raw(&cuda_buffer);

Review comment:
       Could you use `arrow_` prefix for C++ objects?
   
   ```c++
   auto arrow_buffer_result = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer_result, "[cuda][buffer][new]")) {
     std::shared_ptr<arrow::cuda::CudaBuffer> arrow_buffer = *arrow_buffer_result;
     return garrow_cuda_buffer_new_raw(&arrow_cuda_buffer);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020827832






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020360438


   @github-actions crossbow submit test-ubuntu-default-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020361450






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020827832


   Benchmark runs are scheduled for baseline = c76215f3a13155a66bc95caddca47440e7cece65 and contender = 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6. 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/500e4310a15f401e91a33e25266e96f1...0348b6e0de4f4f22857bb6d6422829a5/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/32bad457fae84aeabf87ba4e5200bdfc...4667bb1a09bc44fbac1a9aa92433e132/)
   [Finished :arrow_down:0.48% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa04a0861fa64662b660287c3de225b9...d8b1a5e76f7f406ebedf7ae5d7aa585f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020743960


   @github-actions crossbow submit test-ubuntu-default-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020744622


   Revision: 02b04091c7ef803362f3114b5245260d4074f8f4
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-1482](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1482)
   
   |Task|Status|
   |----|------|
   |test-ubuntu-default-docs|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-1482-azure-test-ubuntu-default-docs)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1482-azure-test-ubuntu-default-docs)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou closed pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
kou closed pull request #12237:
URL: https://github.com/apache/arrow/pull/12237


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#discussion_r791280678



##########
File path: c_glib/arrow-cuda-glib/cuda.cpp
##########
@@ -288,7 +288,9 @@ garrow_cuda_buffer_new(GArrowCUDAContext *context,
   auto arrow_context = garrow_cuda_context_get_raw(context);
   auto arrow_buffer = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer, "[cuda][buffer][new]")) {
-    return garrow_cuda_buffer_new_raw(&(*arrow_buffer));
+    std::shared_ptr<arrow::cuda::CudaBuffer> cuda_buffer =
+      arrow_buffer.MoveValueUnsafe();
+    return garrow_cuda_buffer_new_raw(&cuda_buffer);

Review comment:
       Could you use `arrow_` prefix for C++ objects?
   
   ```c++
   auto arrow_buffer_result = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer_result, "[cuda][buffer][new]")) {
     std::shared_ptr<arrow::cuda::CudaBuffer> arrow_buffer = *arrow_buffer_result;
     return garrow_cuda_buffer_new_raw(&arrow_cuda_buffer);
   ```

##########
File path: c_glib/arrow-cuda-glib/cuda.cpp
##########
@@ -288,7 +288,9 @@ garrow_cuda_buffer_new(GArrowCUDAContext *context,
   auto arrow_context = garrow_cuda_context_get_raw(context);
   auto arrow_buffer = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer, "[cuda][buffer][new]")) {
-    return garrow_cuda_buffer_new_raw(&(*arrow_buffer));
+    std::shared_ptr<arrow::cuda::CudaBuffer> cuda_buffer =
+      arrow_buffer.MoveValueUnsafe();
+    return garrow_cuda_buffer_new_raw(&cuda_buffer);

Review comment:
       Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020132465


   https://issues.apache.org/jira/browse/ARROW-15424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020360438


   @github-actions crossbow submit test-ubuntu-default-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020743960


   @github-actions crossbow submit test-ubuntu-default-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020827832


   Benchmark runs are scheduled for baseline = c76215f3a13155a66bc95caddca47440e7cece65 and contender = 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6. 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/500e4310a15f401e91a33e25266e96f1...0348b6e0de4f4f22857bb6d6422829a5/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/32bad457fae84aeabf87ba4e5200bdfc...4667bb1a09bc44fbac1a9aa92433e132/)
   [Finished :arrow_down:0.48% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa04a0861fa64662b660287c3de225b9...d8b1a5e76f7f406ebedf7ae5d7aa585f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm commented on a change in pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#discussion_r791282031



##########
File path: c_glib/arrow-cuda-glib/cuda.cpp
##########
@@ -288,7 +288,9 @@ garrow_cuda_buffer_new(GArrowCUDAContext *context,
   auto arrow_context = garrow_cuda_context_get_raw(context);
   auto arrow_buffer = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer, "[cuda][buffer][new]")) {
-    return garrow_cuda_buffer_new_raw(&(*arrow_buffer));
+    std::shared_ptr<arrow::cuda::CudaBuffer> cuda_buffer =
+      arrow_buffer.MoveValueUnsafe();
+    return garrow_cuda_buffer_new_raw(&cuda_buffer);

Review comment:
       Ah, ok, I've updated it. (There still needs to be a std::move to convert from unique_ptr to shared_ptr, though.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#discussion_r791283695



##########
File path: c_glib/arrow-cuda-glib/cuda.cpp
##########
@@ -288,7 +288,9 @@ garrow_cuda_buffer_new(GArrowCUDAContext *context,
   auto arrow_context = garrow_cuda_context_get_raw(context);
   auto arrow_buffer = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer, "[cuda][buffer][new]")) {
-    return garrow_cuda_buffer_new_raw(&(*arrow_buffer));
+    std::shared_ptr<arrow::cuda::CudaBuffer> cuda_buffer =
+      arrow_buffer.MoveValueUnsafe();
+    return garrow_cuda_buffer_new_raw(&cuda_buffer);

Review comment:
       Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020827832


   Benchmark runs are scheduled for baseline = c76215f3a13155a66bc95caddca47440e7cece65 and contender = 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6. 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/500e4310a15f401e91a33e25266e96f1...0348b6e0de4f4f22857bb6d6422829a5/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/32bad457fae84aeabf87ba4e5200bdfc...4667bb1a09bc44fbac1a9aa92433e132/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa04a0861fa64662b660287c3de225b9...d8b1a5e76f7f406ebedf7ae5d7aa585f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020361450


   Revision: 4ce284d7ffc9abd8acb3e757666a078d8f528131
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-1475](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1475)
   
   |Task|Status|
   |----|------|
   |test-ubuntu-default-docs|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-1475-azure-test-ubuntu-default-docs)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1475-azure-test-ubuntu-default-docs)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm commented on a change in pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#discussion_r791282031



##########
File path: c_glib/arrow-cuda-glib/cuda.cpp
##########
@@ -288,7 +288,9 @@ garrow_cuda_buffer_new(GArrowCUDAContext *context,
   auto arrow_context = garrow_cuda_context_get_raw(context);
   auto arrow_buffer = arrow_context->Allocate(size);
   if (garrow::check(error, arrow_buffer, "[cuda][buffer][new]")) {
-    return garrow_cuda_buffer_new_raw(&(*arrow_buffer));
+    std::shared_ptr<arrow::cuda::CudaBuffer> cuda_buffer =
+      arrow_buffer.MoveValueUnsafe();
+    return garrow_cuda_buffer_new_raw(&cuda_buffer);

Review comment:
       Ah, ok, I've updated it. (There still needs to be a std::move to convert from unique_ptr to shared_ptr, though.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou closed pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
kou closed pull request #12237:
URL: https://github.com/apache/arrow/pull/12237


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12237: ARROW-15424: [C++][GLib] Fix CUDA bindings

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12237:
URL: https://github.com/apache/arrow/pull/12237#issuecomment-1020827832


   Benchmark runs are scheduled for baseline = c76215f3a13155a66bc95caddca47440e7cece65 and contender = 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6. 8b3e067b1afd34e0cebf4d415b0cb10029ebf6f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/500e4310a15f401e91a33e25266e96f1...0348b6e0de4f4f22857bb6d6422829a5/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/32bad457fae84aeabf87ba4e5200bdfc...4667bb1a09bc44fbac1a9aa92433e132/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa04a0861fa64662b660287c3de225b9...d8b1a5e76f7f406ebedf7ae5d7aa585f/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org