You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Maximilian Michels (JIRA)" <ji...@apache.org> on 2016/07/20 12:15:20 UTC

[jira] [Commented] (FLINK-3753) KillerWatchDog should not use kill on toKill thread

    [ https://issues.apache.org/jira/browse/FLINK-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385754#comment-15385754 ] 

Maximilian Michels commented on FLINK-3753:
-------------------------------------------

Thanks for reporting! It actually states in the class why the {{stop()}} method is used. I think we have to work around some issues with the Kafka fetcher.

I would close this issue for now because we want to use {{stop()}} for the KillerWatchDog (scary name!).

> KillerWatchDog should not use kill on toKill thread
> ---------------------------------------------------
>
>                 Key: FLINK-3753
>                 URL: https://issues.apache.org/jira/browse/FLINK-3753
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>     // this is harsh, but this watchdog is a last resort
>     if (toKill.isAlive()) {
>       toKill.stop();
>     }
> {code}
> stop() is deprecated.
> See:
> https://www.securecoding.cert.org/confluence/display/java/THI05-J.+Do+not+use+Thread.stop()+to+terminate+threads



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)