You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jack Dintruff (JIRA)" <ji...@apache.org> on 2012/06/21 17:26:43 UTC
[jira] [Created] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Jack Dintruff created HADOOP-8523:
-------------------------------------
Summary: test-patch.sh is doesn't validate patches before building
Key: HADOOP-8523
URL: https://issues.apache.org/jira/browse/HADOOP-8523
Project: Hadoop Common
Issue Type: Bug
Components: scripts
Affects Versions: 0.23.1
Reporter: Jack Dintruff
Priority: Trivial
When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jonathan Eagles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398703#comment-13398703 ]
Jonathan Eagles commented on HADOOP-8523:
-----------------------------------------
This is looking better. If we can move it right after patch download and before the javac warnings build in setup, then we can see even more speedup!
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Attachments: Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Attachment: HADOOP-8523.patch
Here's a more elegant fix up for review that doesn't require the initial build and allows the Jenkins machines to take advantage of this fix as well.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jonathan Eagles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles updated HADOOP-8523:
------------------------------------
Status: Open (was: Patch Available)
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8523:
----------------------------------------
Status: Open (was: Patch Available)
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408318#comment-13408318 ]
Hudson commented on HADOOP-8523:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2496 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2496/])
HADOOP-8523. test-patch.sh doesn't validate patches before building (Jack Dintruff via jeagles) (Revision 1358394)
Result = SUCCESS
jeagles : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358394
Files :
* /hadoop/common/trunk/dev-support/smart-apply-patch.sh
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Component/s: (was: scripts)
build
Target Version/s: 0.23.3, 2.0.1-alpha (was: 0.23.3)
Affects Version/s: 2.0.1-alpha
Fix Version/s: (was: 0.23.3)
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Attachments: Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410833#comment-13410833 ]
Hudson commented on HADOOP-8523:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2441 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2441/])
HADOOP-8523. test-patch.sh doesn't validate patches before building (Jack Dintruff via jeagles) (Revision 1358394)
Result = SUCCESS
jeagles : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358394
Files :
* /hadoop/common/trunk/dev-support/smart-apply-patch.sh
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408349#comment-13408349 ]
Hudson commented on HADOOP-8523:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1128 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1128/])
HADOOP-8523. test-patch.sh doesn't validate patches before building (Jack Dintruff via jeagles) (Revision 1358394)
Result = SUCCESS
jeagles : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358394
Files :
* /hadoop/common/trunk/dev-support/smart-apply-patch.sh
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Attachment: HADOOP-8523.patch
Here's a new patch, I've tested it myself and it definitely works. It also makes test-patch much easier to understand for future development.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Summary: test-patch.sh doesn't validate patches before building (was: test-patch.sh is doesn't validate patches before building)
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jonathan Eagles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408282#comment-13408282 ]
Jonathan Eagles commented on HADOOP-8523:
-----------------------------------------
Thanks, Jack. I put this into trunk.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Status: Open (was: Patch Available)
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408294#comment-13408294 ]
Hudson commented on HADOOP-8523:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2446 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2446/])
HADOOP-8523. test-patch.sh doesn't validate patches before building (Jack Dintruff via jeagles) (Revision 1358394)
Result = FAILURE
jeagles : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358394
Files :
* /hadoop/common/trunk/dev-support/smart-apply-patch.sh
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400552#comment-13400552 ]
Daryn Sharp commented on HADOOP-8523:
-------------------------------------
I'd suggest keeping this patch minimal and creating another jira for enhanced option handling.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398731#comment-13398731 ]
Hadoop QA commented on HADOOP-8523:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532919/HADOOP-8523.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 13 warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1133//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1133//console
This message is automatically generated.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398561#comment-13398561 ]
Jack Dintruff commented on HADOOP-8523:
---------------------------------------
The smart-apply-patch.sh executes a --dry-run of patch, so I'll add a patch that just moves my check until after setup is called. Thanks for pointing that out.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jonathan Eagles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399564#comment-13399564 ]
Jonathan Eagles commented on HADOOP-8523:
-----------------------------------------
Great! A couple of more things from the new patch. test-patch.sh now aborts at the proper place. We will want to make sure the jira comment is posted to notify the user, similar to how applyPatch is being used. smart-apply-patch.sh looks like it will have the correct results. Also smart patch is getting a bit complicated with its option parsing. Either as part of this JIRA or a new JIRA add getopts parsing to be more robust and extensible with parsing.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410791#comment-13410791 ]
Hudson commented on HADOOP-8523:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2508 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2508/])
HADOOP-8523. test-patch.sh doesn't validate patches before building (Jack Dintruff via jeagles) (Revision 1358394)
Result = SUCCESS
jeagles : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358394
Files :
* /hadoop/common/trunk/dev-support/smart-apply-patch.sh
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jonathan Eagles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398550#comment-13398550 ]
Jonathan Eagles commented on HADOOP-8523:
-----------------------------------------
Thanks for the patch, Jack. I like that this will save me some time as I know I have hit this case before.
Couple of comments. There are two mode this script runs in, from Jenkins to run the commit builds and by developers for testing purposes. Jenkins mode relies on setup to download the patch file from the JIRA, so the check will need to happen after the patch is downloaded. Additionally, setup needs an unpatched build to check if trunk is stable and determine pre-patched javac warnings. Perhaps by adding a --dry-run option to smart-apply-patch this can be achieved.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jonathan Eagles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408243#comment-13408243 ]
Jonathan Eagles commented on HADOOP-8523:
-----------------------------------------
+1. verified test-patch.sh does abort early on badly formatted patches and continues on normally with correctly formatted patches.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Status: Patch Available (was: Open)
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Status: Patch Available (was: Open)
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Status: Patch Available (was: Open)
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Priority: Minor (was: Trivial)
Issue Type: Improvement (was: Bug)
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Status: Open (was: Patch Available)
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Attachment: Hadoop-8523.patch
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398509#comment-13398509 ]
Hadoop QA commented on HADOOP-8523:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532885/Hadoop-8523.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 13 warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1130//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1130//console
This message is automatically generated.
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408325#comment-13408325 ]
Hudson commented on HADOOP-8523:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2428 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2428/])
HADOOP-8523. test-patch.sh doesn't validate patches before building (Jack Dintruff via jeagles) (Revision 1358394)
Result = SUCCESS
jeagles : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358394
Files :
* /hadoop/common/trunk/dev-support/smart-apply-patch.sh
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401584#comment-13401584 ]
Robert Joseph Evans commented on HADOOP-8523:
---------------------------------------------
A couple of comments
# In smart-apply patch we are already figuring out the PLEVEL and by the time it gets to the dryrun check we know that it will already apply with either a p0 p1 or p2 otherwise it would have exited by this point. We really don't need to try and apply the patch yet again.
# Instead of trying to add yet another thing to setup, with a cleanupAndExit in the middle of it. I would prefer to see setup split up into three different functions. One to download the patch, one to test to see if the patch applies, and one to do the initial build.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Attachment: Hadoop-8523.patch
Just moved the smart-apply-patch.sh call to run after setup as per Jon's suggestion..
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
> Attachments: Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jonathan Eagles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Eagles resolved HADOOP-8523.
-------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
2.0.1-alpha
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398628#comment-13398628 ]
Hadoop QA commented on HADOOP-8523:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12532902/Hadoop-8523.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 13 warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1131//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1131//console
This message is automatically generated.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Attachments: Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400558#comment-13400558 ]
Jack Dintruff commented on HADOOP-8523:
---------------------------------------
The patch is about as minimal as I can make it right now. I can definitely start working on a patch with better argument handling and file a separate JIRA for that though. Thanks for the advice.
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8523:
--------------------------------
Fix Version/s: (was: 2.0.1-alpha)
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8523) test-patch.sh doesn't validate
patches before building
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408286#comment-13408286 ]
Hudson commented on HADOOP-8523:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1095 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1095/])
HADOOP-8523. test-patch.sh doesn't validate patches before building (Jack Dintruff via jeagles) (Revision 1358394)
Result = FAILURE
jeagles : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358394
Files :
* /hadoop/common/trunk/dev-support/smart-apply-patch.sh
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.3, 2.0.1-alpha
> Reporter: Jack Dintruff
> Priority: Minor
> Labels: newbie
> Fix For: 2.0.1-alpha, 3.0.0
>
> Attachments: HADOOP-8523.patch, HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8523) test-patch.sh is doesn't validate
patches before building
Posted by "Jack Dintruff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jack Dintruff updated HADOOP-8523:
----------------------------------
Fix Version/s: 0.23.3
Target Version/s: 0.23.3 (was: 0.23.1)
Affects Version/s: (was: 0.23.1)
0.23.3
Status: Patch Available (was: Open)
> test-patch.sh is doesn't validate patches before building
> ---------------------------------------------------------
>
> Key: HADOOP-8523
> URL: https://issues.apache.org/jira/browse/HADOOP-8523
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.23.3
> Reporter: Jack Dintruff
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.3
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or one that doesn't compile, the script spends a lot of time building Hadoop before checking to see if the patch is invalid. It would help devs if it checked first just in case we run test-patch.sh with a bad patch file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira