[jira] Commented: (AXIS2-2714) Unnecessary recording of directionality in MessageContext "executed phases", general improvements to same

["Davanum Srinivas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502814 ] 

Davanum Srinivas commented on AXIS2-2714:
-----------------------------------------

If we have to fix this, let's do it for 1.3. if not, let's mark this as won't fix.

> Unnecessary recording of directionality in MessageContext "executed phases", general improvements to same
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-2714
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2714
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>            Reporter: Glen Daniels
>            Assignee: Glen Daniels
>            Priority: Blocker
>
> When we added the flowComplete() stuff, I think we might have gotten a little unnecessarily specific about direction in MessageContext and AxisEngine.  In particular - a MessageContext will only ever have a single direction, and right now we have two separate LinkedLists for executed phases (sic - it's really Handlers, even though they're usually Phases at the top level).  This bubbles through a lot of the code in AxisEngine too, and it doesn't seem to be necessary.
> I'd like to consider the following two-stage fix for this.
> 1) Remove all the directionality, and simply have MessageContext.addExecutedHandler()/resetExecutedHandlers()/getExecutedHandlers().  This removes a bunch of code from MC (simplify simplify) and cleans up AxisEngine nicely.  
> 2) If AXIS2-2703 is fixed (and therefore a single ExecutionChain will accurately reflect the entire list of executed handlers), we won't even need a separate executedHandlers structure at all, and flowComplete() will then be able to just work backwards from currentHandlerIndex to 0.  At that point I think we could remove it entirely.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org