You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/12 14:34:15 UTC

[GitHub] [arrow] andygrove commented on a change in pull request #7916: ARROW-9673: [Rust] [DataFusion] Add a param "dialect" for DFParser::parse_sql

andygrove commented on a change in pull request #7916:
URL: https://github.com/apache/arrow/pull/7916#discussion_r469305811



##########
File path: rust/datafusion/src/sql/planner.rs
##########
@@ -815,7 +816,8 @@ mod tests {
 
     fn logical_plan(sql: &str) -> Result<LogicalPlan> {
         let planner = SqlToRel::new(MockSchemaProvider {});
-        let ast = DFParser::parse_sql(&sql).unwrap();
+        let dialet = &GenericDialect {};

Review comment:
       typo, should be `dialect`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org