You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "iMashtak (via GitHub)" <gi...@apache.org> on 2023/12/31 11:00:07 UTC
[PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
iMashtak opened a new pull request, #12625:
URL: https://github.com/apache/camel/pull/12625
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
Added choices beetween Epoll and KQueue in all TCP-conntected places and checked that native transport still works fine on Linux. Also removed noisy warnings as i described in Jira task.
Important: I cant properly test this cause i do not have Mac OS or BSD operating system. The main test is `NettyTCPSyncUDSTest` - it tests both consumer and producer. I typed corresponding KQueue* classes basing on Epoll* names.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1440220852
##########
components/camel-netty/src/main/docs/netty-component.adoc:
##########
@@ -614,6 +614,46 @@ This provides support for timeout and other complexities you otherwise would nee
You can find an example with the Apache Camel source code in the examples directory
under the `camel-example-netty-custom-correlation` directory.
+== Native transport
+
+To enable native transport you need to add additional dependency for epoll or kqueue depending on your OS and CPU arch. To make it easier add the following extension to your `build` section of `pom.xml`:
+
Review Comment:
Mind that the build vs runtime platform is not always the same. So a developer may use a M1 but the production system is on linux x86.
So part of the ci/cd pipeline or whatever build process you have then take that into account and include the right set of dependency for the target OS platform.
What is in the current doc is for choosing the arch based on current build platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1879644780
I think this is ready to merge. I'll take a closer look on Monday if isn't merge until then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1440219827
##########
components/camel-netty/src/main/java/org/apache/camel/component/netty/SingleTCPNettyServerBootstrapFactory.java:
##########
@@ -23,15 +23,15 @@
import java.util.concurrent.ThreadFactory;
import io.netty.bootstrap.ServerBootstrap;
-import io.netty.channel.Channel;
-import io.netty.channel.ChannelFuture;
-import io.netty.channel.ChannelInitializer;
-import io.netty.channel.ChannelOption;
-import io.netty.channel.EventLoopGroup;
+import io.netty.channel.*;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1439330629
##########
components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyTCPSyncUDSTest.java:
##########
@@ -19,16 +19,14 @@
import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
- * Add {@code <classifier>linux-x86_64</classifier>} to io.netty:netty-transport-native-epoll dependency to make this
- * test work
+ *
+ * @see <a href="https://netty.io/wiki/native-transports.html">about netty native transport</a>
*/
-@Disabled("Requires native library to load, can be run manually")
Review Comment:
Should it be disabled on Windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #12625:
URL: https://github.com/apache/camel/pull/12625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1872920554
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875652361
> How to retrieve logs from failed build? I see there somewhere `incremental-test.log` but cant find:(
ASF restricts access to the logs to the committers. So, when there's a failure, just drop a message and we can download it. That said, I see it is working now ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1873019632
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1872952876
That can maybe be made via some maven profile stuff that matches host os and select correct dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1873019569
/component-test camel-netty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875452561
> @orpiske fixed - i add not `x86`, but `amd64` - as far as i understand this names are equivalent
Thanks. It's looking good on s390x and Power now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875514268
:robot: The Apache Camel test robot will run the tests for you :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1439449921
##########
components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyTCPSyncUDSTest.java:
##########
@@ -19,16 +19,14 @@
import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
- * Add {@code <classifier>linux-x86_64</classifier>} to io.netty:netty-transport-native-epoll dependency to make this
- * test work
+ *
+ * @see <a href="https://netty.io/wiki/native-transports.html">about netty native transport</a>
*/
-@Disabled("Requires native library to load, can be run manually")
Review Comment:
I will fix it, ok
What kind of note?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1439481205
##########
components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyTCPSyncUDSTest.java:
##########
@@ -19,16 +19,14 @@
import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
- * Add {@code <classifier>linux-x86_64</classifier>} to io.netty:netty-transport-native-epoll dependency to make this
- * test work
+ *
+ * @see <a href="https://netty.io/wiki/native-transports.html">about netty native transport</a>
*/
-@Disabled("Requires native library to load, can be run manually")
Review Comment:
For the note, I was thinking to provide a mention that `native transport` is supported on Linux with epoll and Mac with kqueue. Maybe on the `unixDomainSocketPath` https://github.com/apache/camel/blob/0fb44f713f4eedb450970fe4b40a59c2cb2ab6dc/components/camel-netty/src/main/java/org/apache/camel/component/netty/NettyServerBootstrapConfiguration.java#L582
and I understand well that the end-user must add some specific classifier on Mac to make it working (is it right?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1440218270
##########
components/camel-netty/src/main/java/org/apache/camel/component/netty/SingleTCPNettyServerBootstrapFactory.java:
##########
@@ -23,15 +23,15 @@
import java.util.concurrent.ThreadFactory;
import io.netty.bootstrap.ServerBootstrap;
-import io.netty.channel.Channel;
-import io.netty.channel.ChannelFuture;
-import io.netty.channel.ChannelInitializer;
-import io.netty.channel.ChannelOption;
-import io.netty.channel.EventLoopGroup;
+import io.netty.channel.*;
Review Comment:
There is a maven plugin that automatic does import "fixes" - so its usually a matter of rebuilding the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1440202659
##########
components/camel-netty/src/main/java/org/apache/camel/component/netty/SingleTCPNettyServerBootstrapFactory.java:
##########
@@ -23,15 +23,15 @@
import java.util.concurrent.ThreadFactory;
import io.netty.bootstrap.ServerBootstrap;
-import io.netty.channel.Channel;
-import io.netty.channel.ChannelFuture;
-import io.netty.channel.ChannelInitializer;
-import io.netty.channel.ChannelOption;
-import io.netty.channel.EventLoopGroup;
+import io.netty.channel.*;
Review Comment:
Sorry for the nitpick, but we don't usually use start imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1440362071
##########
components/camel-netty/src/main/docs/netty-component.adoc:
##########
@@ -614,6 +614,46 @@ This provides support for timeout and other complexities you otherwise would nee
You can find an example with the Apache Camel source code in the examples directory
under the `camel-example-netty-custom-correlation` directory.
+== Native transport
+
+To enable native transport you need to add additional dependency for epoll or kqueue depending on your OS and CPU arch. To make it easier add the following extension to your `build` section of `pom.xml`:
+
Review Comment:
Ok, what exactly may i add to docs?
It is difficult to provide recommendations for all project setups. It may be standalone app, Spring/Quarkus, Jbang or anything else. Should the docs provide information about each setup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1439481205
##########
components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyTCPSyncUDSTest.java:
##########
@@ -19,16 +19,14 @@
import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
- * Add {@code <classifier>linux-x86_64</classifier>} to io.netty:netty-transport-native-epoll dependency to make this
- * test work
+ *
+ * @see <a href="https://netty.io/wiki/native-transports.html">about netty native transport</a>
*/
-@Disabled("Requires native library to load, can be run manually")
Review Comment:
For the note, I was thinking to provide a mention that `native transport` is supported on Linux with epoll and Mac with kqueue. Maybe on the `unixDomainSocketPath` https://github.com/apache/camel/blob/0fb44f713f4eedb450970fe4b40a59c2cb2ab6dc/components/camel-netty/src/main/java/org/apache/camel/component/netty/NettyServerBootstrapConfiguration.java#L582
and if I understand well that the end-user must add some specific classifier on Mac to make it working (is it right?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1439449921
##########
components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyTCPSyncUDSTest.java:
##########
@@ -19,16 +19,14 @@
import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
- * Add {@code <classifier>linux-x86_64</classifier>} to io.netty:netty-transport-native-epoll dependency to make this
- * test work
+ *
+ * @see <a href="https://netty.io/wiki/native-transports.html">about netty native transport</a>
*/
-@Disabled("Requires native library to load, can be run manually")
Review Comment:
I fill fix it, ok
What kind of note?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1440244061
##########
components/camel-netty/src/main/java/org/apache/camel/component/netty/SingleTCPNettyServerBootstrapFactory.java:
##########
@@ -23,15 +23,15 @@
import java.util.concurrent.ThreadFactory;
import io.netty.bootstrap.ServerBootstrap;
-import io.netty.channel.Channel;
-import io.netty.channel.ChannelFuture;
-import io.netty.channel.ChannelInitializer;
-import io.netty.channel.ChannelOption;
-import io.netty.channel.EventLoopGroup;
+import io.netty.channel.*;
Review Comment:
Thanks @iMashtak!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1872963470
Thanks, Claus:)
I will research that thing, never did such maven profiles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1872951276
java.lang.UnsatisfiedLinkError: could not load a native library: netty_transport_native_kqueue_aarch_64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875513226
How to retrieve logs from failed build? I see there somewhere `incremental-test.log` but cant find:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875513538
/component-test camel-netty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875253644
@orpiske fixed - i add not `x86`, but `amd64` - as far as i understand this names are equivalent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875145653
I think you can add `<arch>x86</arch>` to the `epoll` profile activation to fix this. You might need to add another profile for arm as well (if it works on that platform)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1875123465
It's also broken on power:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.485 s
[INFO] Finished at: 2024-01-03T10:09:47Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project camel-netty: Could not resolve dependencies for project org.apache.camel:camel-netty:jar:4.4.0-SNAPSHOT: The following artifacts could not be resolved: io.netty:netty-transport-native-epoll:jar:linux-ppcle_64:4.1.104.Final (absent): Could not find artifact io.netty:netty-transport-native-epoll:jar:linux-ppcle_64:4.1.104.Final in central (https://repo1.maven.org/maven2/) -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on code in PR #12625:
URL: https://github.com/apache/camel/pull/12625#discussion_r1439721733
##########
components/camel-netty/src/test/java/org/apache/camel/component/netty/NettyTCPSyncUDSTest.java:
##########
@@ -19,16 +19,14 @@
import org.apache.camel.Exchange;
import org.apache.camel.Processor;
import org.apache.camel.builder.RouteBuilder;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
- * Add {@code <classifier>linux-x86_64</classifier>} to io.netty:netty-transport-native-epoll dependency to make this
- * test work
+ *
+ * @see <a href="https://netty.io/wiki/native-transports.html">about netty native transport</a>
*/
-@Disabled("Requires native library to load, can be run manually")
Review Comment:
Not only on Mac - on Linux too. User must include library with bindings, for example:
```xml
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<version>${netty-version}</version>
<classifier>linux-x86_64</classifier>
</dependency>
```
I will make soon new doc-section about native transports for netty - i think that will be more pretty then any setting description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1872951036
on mac with M1 I get this test error
```
[INFO] Running org.apache.camel.component.netty.NettyTCPSyncUDSTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.427 s <<< FAILURE! -- in org.apache.camel.component.netty.NettyTCPSyncUDSTest
[ERROR] org.apache.camel.component.netty.NettyTCPSyncUDSTest.test -- Time elapsed: 0.188 s <<< ERROR!
java.lang.IllegalStateException: Unable to use native transport - both Epoll and KQueue are not available
at org.apache.camel.component.netty.NettyServerBossPoolBuilder.build(NettyServerBossPoolBuilder.java:84)
at org.apache.camel.component.netty.SingleTCPNettyServerBootstrapFactory.startServerBootstrap(SingleTCPNettyServerBootstrapFactory.java:136)
at org.apache.camel.component.netty.SingleTCPNettyServerBootstrapFactory.doStart(SingleTCPNettyServerBootstrapFactory.java:117)
at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
at org.apache.camel.component.netty.NettyConsumer.doStart(NettyConsumer.java:75)
at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
at org.apache.camel.impl.engine.AbstractCamelContext.startService(AbstractCamelContext.java:3092)
at org.apache.camel.impl.engine.InternalRouteStartupManager.doStartOrResumeRouteConsumers(InternalRouteStartupManager.java:408)
at org.apache.camel.impl.engine.InternalRouteStartupManager.doStartRouteConsumers(InternalRouteStartupManager.java:325)
at org.apache.camel.impl.engine.InternalRouteStartupManager.safelyStartRouteServices(InternalRouteStartupManager.java:211)
at org.apache.camel.impl.engine.InternalRouteStartupManager.doStartOrResumeRoutes(InternalRouteStartupManager.java:144)
at org.apache.camel.impl.engine.AbstractCamelContext.doStartCamel(AbstractCamelContext.java:2816)
at org.apache.camel.impl.engine.AbstractCamelContext.doStartContext(AbstractCamelContext.java:2497)
at org.apache.camel.impl.engine.AbstractCamelContext.doStart(AbstractCamelContext.java:2452)
at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
at org.apache.camel.impl.engine.AbstractCamelContext.start(AbstractCamelContext.java:2057)
at org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:208)
at org.apache.camel.test.junit5.CamelTestSupport.startCamelContext(CamelTestSupport.java:765)
at org.apache.camel.test.junit5.CamelTestSupport.doSetUp(CamelTestSupport.java:540)
at org.apache.camel.test.junit5.CamelTestSupport.setUp(CamelTestSupport.java:378)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20286 camel-netty: add support for native transport over kqueue and fixed UDS-connected warnings [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #12625:
URL: https://github.com/apache/camel/pull/12625#issuecomment-1872952597
Okay it works when I use aarch64
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-kqueue</artifactId>
<classifier>osx-aarch_64</classifier>
</dependency>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org