[jira] Commented: (CAMEL-1203) REST (Restlet based) component

["William Tam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/activemq/browse/CAMEL-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48408#action_48408 ] 

William Tam commented on CAMEL-1203:
------------------------------------

I added header filter strategy to the component.  I don't think it is necessary to filter any headers coming from Restlet messages by default.  On the "copying to Restlet header" direction, I filtered the login/password in and any org.restlet stuff headers from Camel message headers.  I removed copying properties from Camel exchange to Restlet header (we only propagate camel message headers).

Claus,
* I logged the exchange in "Exchange is incapable of receiving response" as you suggested.
* I removed the check for null return from mandatoryLookup.
* Regarding the WARN logging, Basically, if the MEP is not out capable, the options are:  1) set the out message. 2) set the in message. 3) set in and out messages. 4) set nothing.  Set nothing is to enforce MEP which I like but I am not sure we are doing that in other components.   Set in and out messages is probably the surest way for client to receive the response (even when MEP is misconfigured).  If we log a DEBUG instead of a WARN, the user won't get spammed but the response is not set.  He may not know why he does not get an response.  I have changed it to throw an exception currently but I am happy to change it and open for suggestion.
* I reverted the try/catch in start/stop.  My thought was to make sure the super.doStop() get a chance to clean things up but I am not worry about it now.  I shouldn't have put the try/catch in doStart().
* I'll capitalize Attached in debug.
Thanks for your feedbacks.

> REST (Restlet based) component
> ------------------------------
>
>                 Key: CAMEL-1203
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1203
>             Project: Apache Camel
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Przemyslaw Budzik
>            Assignee: William Tam
>         Attachments: basic_auth.patch, CAMEL-1203.patch, camel-restlet.patch, status.patch
>
>
> This is the code I was talking with James which we are using in SubRecord. It is minimalistic, but does its job for both consumer and producer and is very easy to use. If you want could be a replacement for the current camel-rest (or could be merged).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.