You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/04/26 17:06:27 UTC
[GitHub] zeppelin pull request #2292: [HOTFIX] Removed adduser while creating note
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/2292
[HOTFIX] Removed adduser while creating note
### What is this PR for?
Adding user paragraph while creating paragraph makes default paragraph and user paragraph have same reference. It breaks personalized mode works well.
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
* [x] - Remove `addUser` from `createParagraph`
* [x] - Add test case for it
### What is the Jira issue?
N/A
### How should this be tested?
N/A
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin hotfix/remove-wrong-adduser-and-add-testcase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2292
----
commit 6ed521a4ba78e736edd0d491e57fa655fc831955
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-04-26T17:01:23Z
Removed adduser while creating note
Added test to guarantee paragraph.getUserParagraph is different from paragraph itself
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2292: [HOTFIX] Remove adduser while creating note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/2292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2292: [HOTFIX] Remove adduser while creating note
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2292: [HOTFIX] Remove adduser while creating note
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/2292
[HOTFIX] Remove adduser while creating note
### What is this PR for?
Adding user paragraph while creating paragraph makes default paragraph and user paragraph have same reference. It breaks personalized mode works well.
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
* [x] - Remove `addUser` from `createParagraph`
* [x] - Add test case for it
### What is the Jira issue?
N/A
### How should this be tested?
N/A
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin hotfix/remove-wrong-adduser-and-add-testcase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2292
----
commit 6ed521a4ba78e736edd0d491e57fa655fc831955
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-04-26T17:01:23Z
Removed adduser while creating note
Added test to guarantee paragraph.getUserParagraph is different from paragraph itself
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2292: [HOTFIX] Removed adduser while creating note
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2292
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2292: [HOTFIX] Remove adduser while creating note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/2292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2292: [HOTFIX] Remove adduser while creating note
Posted by jongyoul <gi...@git.apache.org>.
GitHub user jongyoul reopened a pull request:
https://github.com/apache/zeppelin/pull/2292
[HOTFIX] Remove adduser while creating note
### What is this PR for?
Adding user paragraph while creating paragraph makes default paragraph and user paragraph have same reference. It breaks personalized mode works well.
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
* [x] - Remove `addUser` from `createParagraph`
* [x] - Add test case for it
### What is the Jira issue?
N/A
### How should this be tested?
N/A
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin hotfix/remove-wrong-adduser-and-add-testcase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2292
----
commit 6ed521a4ba78e736edd0d491e57fa655fc831955
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-04-26T17:01:23Z
Removed adduser while creating note
Added test to guarantee paragraph.getUserParagraph is different from paragraph itself
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---