You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2015/09/11 19:31:17 UTC

Review Request 38309: Properly hide the job dashboard link if no dashboard link is configured.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38309/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Repository: aurora


Description
-------

Properly hide the job dashboard link if no dashboard link is configured.


Diffs
-----

  src/main/resources/scheduler/assets/breadcrumb.html 6bb3974c3e390a979a98c951b179bd52dd35c749 

Diff: https://reviews.apache.org/r/38309/diff/


Testing
-------

./gradlew jsHint

Verified dashboard link is not displayed if `statsUrlPrefix` is not set on `response.serverInfo`, is displayed if it is.


Thanks,

Joshua Cohen


Re: Review Request 38309: Properly hide the job dashboard link if no dashboard link is configured.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38309/#review98631
-----------------------------------------------------------

Ship it!


Thanks!

- Bill Farner


On Sept. 11, 2015, 10:31 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38309/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 10:31 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Properly hide the job dashboard link if no dashboard link is configured.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/breadcrumb.html 6bb3974c3e390a979a98c951b179bd52dd35c749 
> 
> Diff: https://reviews.apache.org/r/38309/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew jsHint
> 
> Verified dashboard link is not displayed if `statsUrlPrefix` is not set on `response.serverInfo`, is displayed if it is.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>