You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/01/06 16:17:25 UTC

[Bug 6277] New: Add a verbose option to sa-update to show updated channels

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

           Summary: Add a verbose option to sa-update to show updated
                    channels
           Product: Spamassassin
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sa-update
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: Bowie_Bailey@buc.com


The attached patch will add a verbose option (-v|--verbose) that will output
the channel name of all channels which were updated during the run.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P3
           Platform|Other                       |All
   Target Milestone|Undefined                   |3.3.0

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] [review] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
            Summary|Add a verbose option to     |[review] Add a verbose
                   |sa-update to show updated   |option to sa-update to show
                   |channels                    |updated channels

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] [review] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

--- Comment #5 from Justin Mason <jm...@jmason.org> 2010-01-11 08:09:10 UTC ---
+1 to round up ;)

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4621|0                           |1
        is obsolete|                            |

--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2010-01-06 08:26:19 UTC ---
Created an attachment (id=4622)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4622)
Slightly expanded patch, provides more verbosity

Proposed patch.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] [review] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |needs 1.1 votes

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

--- Comment #1 from Bowie <Bo...@buc.com> 2010-01-06 07:18:08 UTC ---
Created an attachment (id=4621)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4621)
Verbose option patch

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] [review] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jm@jmason.org

--- Comment #3 from Justin Mason <jm...@jmason.org> 2010-01-07 14:10:04 UTC ---
+0.9

+      print "Update was available, but not installed installed in checkonly
mode\n";

drop one of those 'installed's.

+  -v, --verbose           Be more verbose, like print updated channel names

Does the new patch still do that?  (it probably should)

also, I don't think it needs to exclude the --debug case; if --verbose is
indeed used too, the user wants both the verbose msgs and the debugs too IMO.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] [review] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Warren Togami <wt...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 1.1 votes             |ready for commit

--- Comment #6 from Warren Togami <wt...@redhat.com> 2010-01-11 08:13:00 UTC ---
+1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] [review] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4622|0                           |1
        is obsolete|                            |

--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2010-01-07 17:24:16 UTC ---
Created an attachment (id=4629)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4629)
proposed patch, v2

> + print "Update was available, but not installed installed in checkonly
> mode\n";
> drop one of those 'installed's.

Thanks, done.

> +  -v, --verbose           Be more verbose, like print updated channel names
> Does the new patch still do that?  (it probably should)

Does it still print updated channel names? Yes it does (like in the
original patch), but prefixed by a text 'Update available for channel '.

This only applies to network downloads. An equivalent print for
updates from a file is commented out, it's probably redundant.


> also, I don't think it needs to exclude the --debug case; if --verbose is
> indeed used too, the user wants both the verbose msgs and the debugs too IMO.

Agreed. It also allows print lines to fit into a single line, nicer!

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6277] [review] Add a verbose option to sa-update to show updated channels

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6277

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Mark Martinec <Ma...@ijs.si> 2010-01-11 08:33:09 UTC ---
Bug 6277: Add a verbose option to sa-update to show updated channels
Sending sa-update.raw
Committed revision 897929.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.