[GitHub] [incubator-inlong] charlely commented on a change in pull request #474: [INLONG-619]Configuration for Go SDK.

[GitBox <gi...@apache.org>]

charlely commented on a change in pull request #474:
URL: https://github.com/apache/incubator-inlong/pull/474#discussion_r638546005



##########
File path: tubemq-client-twins/tubemq-client-go/config/config.go
##########
@@ -19,14 +19,184 @@
 package config
 
 import (
+	"fmt"
+	"net/url"
+	"strconv"
+	"strings"
 	"time"
 )
 
 // Config defines multiple configuration options.
 type Config struct {
-	// Net iis the namespace for network-level properties used by Broker and Master.
+	// Net is the namespace for network-level properties used by Broker and Master.
 	Net struct {
 		// How long to wait for a response.
 		ReadTimeout time.Duration
+		// TLS based authentication with broker and master.
+		TLS         struct {
+			// Whether or not to use TLS.
+			Enable bool
+			// CACertFile for TLS.
+			CACertFile string
+			// TLSCertFile for TLS.
+			TLSCertFile string
+			// TLSKeyFile for TLS.
+			TLSKeyFile string
+			// TTSServerName for TLS.
+			TLSServerName string
+		}
 	}
+
+	// Consumer is the namespace for configuration related to consume messages,
+	// used by the consumer
+	Consumer struct {
+		masters []string

Review comment:
       How do external packages use these non-exported parameters?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org