You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2015/03/16 15:47:34 UTC
[GitHub] activemq-6 pull request: Fix proton-cpp pom missing version
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-6/pull/187
Fix proton-cpp pom missing version
Fix proton-cpp pom missing version
Fix proton-ruby script (update according to proton 0.8)
Fix core example doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-6 master_examples_doc_check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit 5ea0a3055dd38e781f172e5247ab3c136cae876d
Author: Howard Gao <hg...@redhat.com>
Date: 2015-03-16T14:39:00Z
Fix proton-cpp pom missing version
Fix proton-ruby script (update according to proton 0.8)
Fix core example doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Fix proton-cpp pom missing version
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-6/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Fix proton-cpp pom missing version
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-6/pull/187#discussion_r26491141
--- Diff: examples/jms/proton-cpp/pom.xml ---
@@ -50,6 +50,7 @@ under the License.
<dependency>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-jms_2.0_spec</artifactId>
+ <version>${geronimo.jms.2.spec.version}</version>
--- End diff --
this version shouldnt be needed Howard?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Fix proton-cpp pom missing version
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-6/pull/187#discussion_r26541600
--- Diff: examples/jms/proton-cpp/pom.xml ---
@@ -50,6 +50,7 @@ under the License.
<dependency>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-jms_2.0_spec</artifactId>
+ <version>${geronimo.jms.2.spec.version}</version>
--- End diff --
you will get error if you don't add this version tag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: Fix proton-cpp pom missing version
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-6/pull/187#discussion_r26543718
--- Diff: examples/jms/proton-cpp/pom.xml ---
@@ -50,6 +50,7 @@ under the License.
<dependency>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-jms_2.0_spec</artifactId>
+ <version>${geronimo.jms.2.spec.version}</version>
--- End diff --
I rewrote the example.. there is a java class missing.. and I"m not sure why.. maybe I missed something when I committed it..
I have added a new PR closing this one.. this should be moot.. your commit has been imported on my PR>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---