You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sander Plas (JIRA)" <ji...@apache.org> on 2012/05/31 14:01:24 UTC
[jira] [Created] (WICKET-4578) Link always causes Page to become
stateful, regardless of visibility
Sander Plas created WICKET-4578:
-----------------------------------
Summary: Link always causes Page to become stateful, regardless of visibility
Key: WICKET-4578
URL: https://issues.apache.org/jira/browse/WICKET-4578
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.6
Reporter: Sander Plas
Priority: Minor
Despite the changes made in WICKET-4468 , an invisible Link still causes a Page to become stateful.
The problem seems to be that Component#isStateless does this before even checking the visibility:
if (!getStatelessHint())
{
return false;
}
... and Link#getStatelessHint() just contains just "return false" .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4578) Link always causes Page to become
stateful, regardless of visibility
Posted by "Sander Plas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sander Plas updated WICKET-4578:
--------------------------------
Attachment: WICKET-4578.diff
proposed fix for Component & ComponentTest
> Link always causes Page to become stateful, regardless of visibility
> --------------------------------------------------------------------
>
> Key: WICKET-4578
> URL: https://issues.apache.org/jira/browse/WICKET-4578
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Sander Plas
> Priority: Minor
> Attachments: WICKET-4578.diff, invisibleStatefulTest.zip
>
>
> Despite the changes made in WICKET-4468 , an invisible Link still causes a Page to become stateful.
> The problem seems to be that Component#isStateless does this before even checking the visibility:
> if (!getStatelessHint())
> {
> return false;
> }
> ... and Link#getStatelessHint() just contains just "return false" .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4578) Link always causes Page to become
stateful, regardless of visibility
Posted by "Sander Plas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sander Plas updated WICKET-4578:
--------------------------------
Attachment: invisibleStatefulTest.zip
A *very* basic quickstart showing a page with an invisible link that becomes stateful.
> Link always causes Page to become stateful, regardless of visibility
> --------------------------------------------------------------------
>
> Key: WICKET-4578
> URL: https://issues.apache.org/jira/browse/WICKET-4578
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Sander Plas
> Priority: Minor
> Attachments: invisibleStatefulTest.zip
>
>
> Despite the changes made in WICKET-4468 , an invisible Link still causes a Page to become stateful.
> The problem seems to be that Component#isStateless does this before even checking the visibility:
> if (!getStatelessHint())
> {
> return false;
> }
> ... and Link#getStatelessHint() just contains just "return false" .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4578) Link always causes Page to become
stateful, regardless of visibility
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4578.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.8
6.0.0-RC1
Assignee: Martin Grigorov
> Link always causes Page to become stateful, regardless of visibility
> --------------------------------------------------------------------
>
> Key: WICKET-4578
> URL: https://issues.apache.org/jira/browse/WICKET-4578
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.6
> Reporter: Sander Plas
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.0.0-RC1, 1.5.8
>
> Attachments: WICKET-4578.diff, invisibleStatefulTest.zip
>
>
> Despite the changes made in WICKET-4468 , an invisible Link still causes a Page to become stateful.
> The problem seems to be that Component#isStateless does this before even checking the visibility:
> if (!getStatelessHint())
> {
> return false;
> }
> ... and Link#getStatelessHint() just contains just "return false" .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira