You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/09/27 18:32:29 UTC
[GitHub] [trafficserver] ywkaras opened a new pull request, #9109: Change use of std::shared_mutex to ts::shared_mutex.
ywkaras opened a new pull request, #9109:
URL: https://github.com/apache/trafficserver/pull/9109
Typically when shared_mutex is used, the ratio of shared_locks versus unique_locks is high, so writer starvation is a risk. On Linux, ts::shared_mutex avoids writer starvation (std::shared_mutex does not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9109: Change use of std::shared_mutex to ts::shared_mutex.
Posted by GitBox <gi...@apache.org>.
masaori335 commented on code in PR #9109:
URL: https://github.com/apache/trafficserver/pull/9109#discussion_r981984747
##########
iocore/net/SSLSessionCache.cc:
##########
@@ -25,6 +25,7 @@
#include <cstring>
#include <memory>
+#include <shared_mutex>
Review Comment:
nvm. SSLSessionCache.cc has `std::shared_lock`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9109: Change use of std::shared_mutex to ts::shared_mutex.
Posted by GitBox <gi...@apache.org>.
masaori335 commented on code in PR #9109:
URL: https://github.com/apache/trafficserver/pull/9109#discussion_r981916384
##########
iocore/net/SSLSessionCache.cc:
##########
@@ -25,6 +25,7 @@
#include <cstring>
#include <memory>
+#include <shared_mutex>
Review Comment:
`<tscpp/util/TsSharedMutex.h>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9109: Change use of std::shared_mutex to ts::shared_mutex.
Posted by GitBox <gi...@apache.org>.
masaori335 commented on code in PR #9109:
URL: https://github.com/apache/trafficserver/pull/9109#discussion_r981980225
##########
iocore/net/TLSKeyLogger.cc:
##########
@@ -23,6 +23,7 @@
#include "tscore/Diags.h"
#include <cstring>
+#include <shared_mutex>
Review Comment:
nvm, TLSKeyLogger used `std::shared_lock`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9109: Change use of std::shared_mutex to ts::shared_mutex.
Posted by GitBox <gi...@apache.org>.
masaori335 commented on code in PR #9109:
URL: https://github.com/apache/trafficserver/pull/9109#discussion_r981951200
##########
iocore/net/TLSKeyLogger.cc:
##########
@@ -23,6 +23,7 @@
#include "tscore/Diags.h"
#include <cstring>
+#include <shared_mutex>
Review Comment:
Why do we need this? This PR is replacing all `std::shared_mutex`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras merged pull request #9109: Change use of std::shared_mutex to ts::shared_mutex.
Posted by GitBox <gi...@apache.org>.
ywkaras merged PR #9109:
URL: https://github.com/apache/trafficserver/pull/9109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org