You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/12/23 17:09:47 UTC
[PR] chore: Refactor `CometScanRule` to improve scan selection and fallback logic [datafusion-comet]
andygrove opened a new pull request, #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Refactor `CometScanRule` to improve scan selection and fallback logic [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978#discussion_r2665268182
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -145,21 +145,9 @@ case class CometScanRule(session: SparkSession) extends Rule[SparkPlan] with Com
if (!CometScanExec.isFileFormatSupported(r.fileFormat)) {
return withInfo(scanExec, s"Unsupported file format ${r.fileFormat}")
}
+ val hadoopConf = r.sparkSession.sessionState.newHadoopConfWithOptions(r.options)
- var scanImpl = COMET_NATIVE_SCAN_IMPL.get()
-
- val hadoopConf = scanExec.relation.sparkSession.sessionState
- .newHadoopConfWithOptions(scanExec.relation.options)
-
- // if scan is auto then pick the best available scan
- if (scanImpl == SCAN_AUTO) {
- scanImpl = selectScan(scanExec, r.partitionSchema, hadoopConf)
- }
-
- if (scanImpl == SCAN_NATIVE_DATAFUSION && !CometNativeScan.isSupported(scanExec)) {
- return scanExec
- }
-
+ // TODO is this restriction valid for all native scan types?
Review Comment:
Yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Refactor `CometScanRule` to improve scan selection and fallback logic [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978#issuecomment-3687438156
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2978?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 9.98%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5bae0ad`](https://app.codecov.io/gh/apache/datafusion-comet/commit/5bae0ad799f1d742949d9b5a789e2f83418998b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 797 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/2978?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/scala/org/apache/comet/rules/CometScanRule.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2978?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Frules%2FCometScanRule.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9ydWxlcy9Db21ldFNjYW5SdWxlLnNjYWxh) | 0.00% | [43 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2978 +/- ##
============================================
- Coverage 56.12% 9.98% -46.15%
+ Complexity 976 234 -742
============================================
Files 119 167 +48
Lines 11743 15500 +3757
Branches 2251 2544 +293
============================================
- Hits 6591 1547 -5044
- Misses 4012 13776 +9764
+ Partials 1140 177 -963
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2978?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Refactor `CometScanRule` to improve scan selection and fallback logic [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978#issuecomment-3719607819
@mbutrovich any objection to merging this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Refactor `CometScanRule` to improve scan selection and fallback logic [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich merged PR #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Refactor `CometScanRule` to improve scan selection and fallback logic [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978#discussion_r2665268182
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -145,21 +145,9 @@ case class CometScanRule(session: SparkSession) extends Rule[SparkPlan] with Com
if (!CometScanExec.isFileFormatSupported(r.fileFormat)) {
return withInfo(scanExec, s"Unsupported file format ${r.fileFormat}")
}
+ val hadoopConf = r.sparkSession.sessionState.newHadoopConfWithOptions(r.options)
- var scanImpl = COMET_NATIVE_SCAN_IMPL.get()
-
- val hadoopConf = scanExec.relation.sparkSession.sessionState
- .newHadoopConfWithOptions(scanExec.relation.options)
-
- // if scan is auto then pick the best available scan
- if (scanImpl == SCAN_AUTO) {
- scanImpl = selectScan(scanExec, r.partitionSchema, hadoopConf)
- }
-
- if (scanImpl == SCAN_NATIVE_DATAFUSION && !CometNativeScan.isSupported(scanExec)) {
- return scanExec
- }
-
+ // TODO is this restriction valid for all native scan types?
Review Comment:
Yep. https://github.com/apache/datafusion-comet/pull/1756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Refactor `CometScanRule` to improve scan selection and fallback logic [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on code in PR #2978:
URL: https://github.com/apache/datafusion-comet/pull/2978#discussion_r2663078667
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -145,21 +145,9 @@ case class CometScanRule(session: SparkSession) extends Rule[SparkPlan] with Com
if (!CometScanExec.isFileFormatSupported(r.fileFormat)) {
return withInfo(scanExec, s"Unsupported file format ${r.fileFormat}")
}
+ val hadoopConf = r.sparkSession.sessionState.newHadoopConfWithOptions(r.options)
- var scanImpl = COMET_NATIVE_SCAN_IMPL.get()
-
- val hadoopConf = scanExec.relation.sparkSession.sessionState
- .newHadoopConfWithOptions(scanExec.relation.options)
-
- // if scan is auto then pick the best available scan
- if (scanImpl == SCAN_AUTO) {
- scanImpl = selectScan(scanExec, r.partitionSchema, hadoopConf)
- }
-
- if (scanImpl == SCAN_NATIVE_DATAFUSION && !CometNativeScan.isSupported(scanExec)) {
- return scanExec
- }
-
+ // TODO is this restriction valid for all native scan types?
Review Comment:
Are default values for primitive types supported by `native_datafusion`?
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -171,31 +159,72 @@ case class CometScanRule(session: SparkSession) extends Rule[SparkPlan] with Com
withInfo(
scanExec,
"Full native scan disabled because nested types for default values are not supported")
Review Comment:
Perhaps should be - "Full native scan disabled because default values for nested types are not supported"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org