You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry via Review Board <no...@reviews.apache.org> on 2020/11/24 05:36:21 UTC
Review Request 73035: Export Service: Incremental: Support Glossary &
Term
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73035/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
Bugs: ATLAS-4024
https://issues.apache.org/jira/browse/ATLAS-4024
Repository: atlas
Description
-------
**Background**
Existing _Export Service_ support export of _AtlasGlossary_. The incremental export option does not support Glossary.
This patch addresses that problem.
**Solution**
Add extraction steps when processing entities.
*Modified* _EntityService_: Additional steps for Term and Glossary extraction.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 8af20576d
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java a85db5cd5
Diff: https://reviews.apache.org/r/73035/diff/1/
Testing
-------
**Functional tests**
Performed export-import-export and compare.
**Pre-commit Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/216/
Thanks,
Ashutosh Mestry
Re: Review Request 73035: Export Service: Incremental: Support
Glossary & Term
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73035/#review222267
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Nov. 30, 2020, 5:52 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73035/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2020, 5:52 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4024
> https://issues.apache.org/jira/browse/ATLAS-4024
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Background**
> Existing _Export Service_ support export of _AtlasGlossary_. The incremental export option does not support Glossary.
>
> This patch addresses that problem.
>
> **Solution**
> Add extraction steps when processing entities.
> *Modified* _EntityService_: Additional steps for Term and Glossary extraction.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 8af20576d
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java a85db5cd5
>
>
> Diff: https://reviews.apache.org/r/73035/diff/2/
>
>
> Testing
> -------
>
> **Functional tests**
> Performed export-import-export and compare.
>
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/216/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 73035: Export Service: Incremental: Support
Glossary & Term
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73035/
-----------------------------------------------------------
(Updated Nov. 30, 2020, 5:52 p.m.)
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
Changes
-------
Updates include:
- Addressed review comments.
- Modified the approach for fetching terms that are only part of the export.
Bugs: ATLAS-4024
https://issues.apache.org/jira/browse/ATLAS-4024
Repository: atlas
Description
-------
**Background**
Existing _Export Service_ support export of _AtlasGlossary_. The incremental export option does not support Glossary.
This patch addresses that problem.
**Solution**
Add extraction steps when processing entities.
*Modified* _EntityService_: Additional steps for Term and Glossary extraction.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 8af20576d
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java a85db5cd5
Diff: https://reviews.apache.org/r/73035/diff/2/
Changes: https://reviews.apache.org/r/73035/diff/1-2/
Testing
-------
**Functional tests**
Performed export-import-export and compare.
**Pre-commit Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/216/
Thanks,
Ashutosh Mestry
Re: Review Request 73035: Export Service: Incremental: Support
Glossary & Term
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
> On Nov. 25, 2020, 3:58 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
> > Lines 302 (patched)
> > <https://reviews.apache.org/r/73035/diff/1/?file=2242120#file2242120line303>
> >
> > It looks like 'term' is only used to retrieve guid of the associated glossary (in the following line). Consider avoiding retrieval of entire term, by adding a method GlossaryService.getGlossaryGuidForTerm(String termGuid).
I have a different approach for this that avoids the need for additional method.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73035/#review222235
-----------------------------------------------------------
On Nov. 30, 2020, 5:52 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73035/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2020, 5:52 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4024
> https://issues.apache.org/jira/browse/ATLAS-4024
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Background**
> Existing _Export Service_ support export of _AtlasGlossary_. The incremental export option does not support Glossary.
>
> This patch addresses that problem.
>
> **Solution**
> Add extraction steps when processing entities.
> *Modified* _EntityService_: Additional steps for Term and Glossary extraction.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 8af20576d
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java a85db5cd5
>
>
> Diff: https://reviews.apache.org/r/73035/diff/2/
>
>
> Testing
> -------
>
> **Functional tests**
> Performed export-import-export and compare.
>
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/216/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 73035: Export Service: Incremental: Support
Glossary & Term
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73035/#review222235
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Lines 302 (patched)
<https://reviews.apache.org/r/73035/#comment311279>
It looks like 'term' is only used to retrieve guid of the associated glossary (in the following line). Consider avoiding retrieval of entire term, by adding a method GlossaryService.getGlossaryGuidForTerm(String termGuid).
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Lines 303 (patched)
<https://reviews.apache.org/r/73035/#comment311277>
It looks like 'glossary' is used only to get its guid (in the following line). Glossary's guid should be available via term.getAnchor().getGlossaryGuid(). Please review if it is necessary to retrieve the glossary object.
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Lines 305 (patched)
<https://reviews.apache.org/r/73035/#comment311278>
toAtlasEntityWithExtInfo() will retrieve entire glossary, including its relationships like terms, categories. Is this intentional?
- Madhan Neethiraj
On Nov. 24, 2020, 5:36 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73035/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2020, 5:36 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4024
> https://issues.apache.org/jira/browse/ATLAS-4024
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Background**
> Existing _Export Service_ support export of _AtlasGlossary_. The incremental export option does not support Glossary.
>
> This patch addresses that problem.
>
> **Solution**
> Add extraction steps when processing entities.
> *Modified* _EntityService_: Additional steps for Term and Glossary extraction.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 8af20576d
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java a85db5cd5
>
>
> Diff: https://reviews.apache.org/r/73035/diff/1/
>
>
> Testing
> -------
>
> **Functional tests**
> Performed export-import-export and compare.
>
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/216/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>