[GitHub] [commons-geometry] darkma773r commented on a change in pull request #111: [GEOMETRY-106] - Refine Module

[GitBox <gi...@apache.org>]

darkma773r commented on a change in pull request #111:
URL: https://github.com/apache/commons-geometry/pull/111#discussion_r538013819



##########
File path: commons-geometry-examples/examples-io/src/main/java/org/apache/commons/geometry/examples/io/threed/AbstractModelIOHandler.java
##########
@@ -35,10 +35,10 @@
     public BoundarySource3D read(final String type, final File in, final DoublePrecisionContext precision) {
         ensureTypeSupported(type);
         try {
-            try (InputStream is = Files.newInputStream(in.toPath())) {
+            try (final InputStream is = Files.newInputStream(in.toPath())) {

Review comment:
       These `final` modifiers on try-with-resources statements are redundant and cause checkstyle failures. You can see these if you run maven with the `mvn clean install -Pcommons-geometry-examples` so that the example modules are included in the build.

##########
File path: commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/Point1S.java
##########
@@ -354,6 +354,7 @@ public static Point1S from(final PolarCoordinates polar) {
      */
     public static Point1S parse(final String str) {
         return SimpleTupleFormat.getDefault().parse(str, (DoubleFunction1N<Point1S>) Point1S::of);
+

Review comment:
       Spurious whitespace?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org