Re: MXNet - Label Bot functionality

[Anirudh Acharya <an...@gmail.com>]

Hi Harsh,

Thanks for working on this. This will be very helpful for people who triage
issues and reviews PRs regularly.

Few concerns from this design document -
https://cwiki.apache.org/confluence/display/MXNET/Machine+Learning+Based+GitHub+Bot
and
the conversation in the comment section

   1. As the scope of the label bot increases, the need for a safety checks
   on who the label bot listens to becomes important. Currently the bot just
   adds labels. You have proposed that the bot also be allowed to remove and
   update labels. And I think allowing the bot to close issues( with a command
   like @mxnet-label-bot close) is in discussion in the comments section. This
   opens up a serious security flaw - anyone who wishes to abuse this system,
   can randomly start closing issues or removing labels. You need to come up
   with a solution so that the bot does not listen to random strangers on the
   internet.
   2. Also you seem to have linked a document that goes to an internal
   amazon website, please remove that.
   [image: Screen Shot 2018-11-01 at 2.31.13 PM.png]


Thanks
Anirudh


On Thu, Oct 18, 2018 at 1:51 PM Harsh Patel <ha...@gmail.com>
wrote:

> Hey,
> After having my PR vetted and reviewed by some contributors, I would like
> to move forward into the stage of putting this into production. I am asking
> for MXNet committers to take a look at my PR regarding the Label Bot.
> https://github.com/MXNetEdge/mxnet-infrastructure/pull/15. This will also
> require access for a webhook - let's set this into motion. Thanks.
>
> Best,
> -Harsh
>
> On Mon, Oct 15, 2018 at 4:05 PM Piyush Ghai <gh...@gmail.com> wrote:
>
> > Hi Harsh,
> >
> > Good job! This is super cool! Especially bringing down the response time
> > to under 20 seconds.
> >
> > Thanks,
> > Piyush
> >
> >
> > > On Oct 15, 2018, at 3:49 PM, Qing Lan <la...@live.com> wrote:
> > >
> > > Hi Harsh,
> > >
> > > This new label bot design looks great! I would like to encourage people
> > to review it and move forward to benefit the MXNet community.
> > > Since this new design needs webhook support from Apache, let's go
> > through the following steps to get this done:
> > >
> > > 1. Demo and contributors review stage: all contributors are encouraged
> > to review the PR here:
> > > https://github.com/MXNetEdge/mxnet-infrastructure/pull/15 and leave
> > your thoughts so Harsh can apply them in his design.
> > > 2. Committers review stage: Once all contributors think the design is
> > good to go, let's get committers involved to get a review.
> > > 3. Committers send request to Apache Infra to get the webhook setup.
> > > 4. Harsh finally deploy the model and all of us can use it in
> > incubator-mxnet repo!
> > >
> > > Some fun fact I would like to share:
> > > 1. This new bot can recommend labels and reply to people who file it!
> > > 2. It response time from 5mins -> less than 20 seconds
> > >
> > > Thanks,
> > > Qing
> > >
> > > On 10/15/18, 11:11 AM, "Harsh Patel" <ha...@gmail.com>
> > wrote:
> > >
> > >    Hey,
> > >    I have a demo available that users and developers can play around
> > with --
> > >    this is in regards to the post I had made regarding the updated
> label
> > bot
> > >    functionality. This is available on my fork (
> > >    https://github.com/harshp8l/incubator-mxnet) if the developers
> would
> > be
> > >    able to provide feedback that would be great.
> > >    The updated usage of this label bot:
> > >    To add labels: @mxnet-label-bot, add ['label1', 'label2']
> > >    To remove labels: @mxnet-label-bot, remove ['label1', 'label2']
> > >    To update labels: @mxnet-label-bot, update ['label3', 'label4']
> > >    (warning: with update - this will remove all other labels for a
> > specific
> > >    issue and update only with the labels the user specifies). Thanks.
> > >
> > >    My PR for reference:
> > >    https://github.com/MXNetEdge/mxnet-infrastructure/pull/15
> > >
> > >    My Design:
> > >
> >
> https://cwiki.apache.org/confluence/display/MXNET/Machine+Learning+Based+GitHub+Bot
> > >
> > >    Best,
> > >    -Harsh
> > >
> > >    On Mon, Oct 15, 2018 at 12:54 AM Hagay Lupesko <lu...@gmail.com>
> > wrote:
> > >
> > >> +1
> > >> Thanks for the contribution!
> > >>
> > >> On Fri, Oct 12, 2018 at 1:41 AM kellen sunderland <
> > >> kellen.sunderland@gmail.com> wrote:
> > >>
> > >>> Awesome work!  Many thanks.
> > >>>
> > >>> On Fri, Oct 12, 2018, 1:19 AM Harsh Patel <
> harshpatel081296@gmail.com>
> > >>> wrote:
> > >>>
> > >>>> Hey,
> > >>>> I am looking to contribute to MXNet. I have a working implementation
> > >>> based
> > >>>> on my proposed design structure according to this wiki page (
> > >>>>
> > >>>>
> > >>>
> > >>
> >
> https://cwiki.apache.org/confluence/display/MXNET/Machine+Learning+Based+GitHub+Bot
> > >>>> )
> > >>>> - under 7.
> > >>>> I have provided users with functionality allowing for adding,
> > updating,
> > >>> and
> > >>>> deleting labels for our issues. The response time with the bot to
> > >> provide
> > >>>> the aforementioned functionality has been reduced as well. Users
> > should
> > >>>> expect speedy updates to labels based on requests made to the label
> > >> bot.
> > >>>> The total number of GitHub API calls have been further reduced as
> well
> > >>>> preventing potential bottlenecks that could result from GitHub.
> > >>>> I would like to have a webhook for this repo:
> > >>>> https://github.com/apache/incubator-mxnet so that this
> functionality
> > >>> will
> > >>>> be used and tested by the developers here. Thanks.
> > >>>>
> > >>>> Best,
> > >>>> -Harsh Patel
> > >>>>
> > >>>
> > >>
> > >
> > >
> >
> >
>